Rename InvoiceItem to ItemInvoice#22
Open
pat wants to merge 2 commits intodavidlumley:masterfrom
Open
Conversation
I find ItemInvoice/item_invoice makes more sense (I initially presumed InvoiceItem was referring to line items in an invoice). This keeps things backwards compatible, at least as a temporary measure.
Include all descendents, not just the first level subclasses of Myob::Api::Model::Base.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find it's more clear this way (rather than a line item within an invoice). I've kept the original naming as well for backwards compatibility, but I'd recommend adding a deprecation warning around that and removing it in a later release.