Update docs to explicitly include redirect uri when creating myob client#29
Closed
darwintantuco wants to merge 5 commits intodavidlumley:masterfrom
Closed
Update docs to explicitly include redirect uri when creating myob client#29darwintantuco wants to merge 5 commits intodavidlumley:masterfrom
darwintantuco wants to merge 5 commits intodavidlumley:masterfrom
Conversation
Author
|
I'm not sure why I closed this PR last year, might be a misclick, |
Author
|
I just realize I don't have access to the source repo anymore, I'll create a new PR so I can fix comment/s if there's any |
Author
|
opened #33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encountered
invalid_requesterror when runningmyob_client.get_access_code_url.Found out that redirect_uri is needed.
It would be nice to see this in README.
Also added support for other invoice types:
(I follow current naming convention, similar to
InvoiceItem)