Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

πŸ›‘οΈ Sentinel: [HIGH] Add security headers & fix CORS

🚨 Severity: HIGH
πŸ’‘ Vulnerability:

  1. Missing standard security headers (HSTS, CSP, X-Frame-Options) exposing users to clickjacking and MIME-sniffing.
  2. Broken CORS configuration where Access-Control-Allow-Origin was not returned for allowed origins on non-preflight requests due to middleware ordering.

🎯 Impact:

  1. Attackers could frame the API (if hosted publicly) or sniff content types.
  2. Legitimate web clients from allowed origins would fail to access the API via POST/GET (browser blocks response).

πŸ”§ Fix:

  1. Added src/security-headers.ts middleware with strict CSP (default-src 'none'), HSTS, and other headers.
  2. Modified src/http-transport.ts to apply security headers.
  3. Fixed src/http-transport.ts to set CORS headers before early-exit checks, ensuring valid origins work.

βœ… Verification:
npm test passes.
New tests in src/security-headers.test.ts and src/testing/http-integration.test.ts verify headers are present.


PR created automatically by Jules for task 12447974312424747695 started by @davidruzicka

- Added `SecurityMiddleware` for HSTS, CSP, X-Frame-Options
- Fixed broken CORS headers for allowed origins
- Added tests for security headers and CORS fix
@google-labs-jules
Copy link
Contributor Author

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… All tests successful. No failed tests found.

πŸ“’ Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants