Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

This change removes a security vulnerability where Origin header validation was skipped for requests to localhost or 127.0.0.1. This behavior could allow malicious websites to perform Cross-Site Request Forgery (CSRF) attacks against a locally running MCP server.

Changes:

  • Modified src/http-transport.ts to remove the early return that bypassed Origin checks for localhost.
  • Updated src/http-transport.test.ts to include a test case verifying that requests with malicious origins are rejected (403 Forbidden) even when the Host is localhost.
  • Initialized .jules/sentinel.md with a journal entry documenting this vulnerability and the fix.

PR created automatically by Jules for task 6786025401319321649 started by @davidruzicka

Removed the exception that skipped Origin header validation when the request target was localhost. This prevents potential CSRF attacks where malicious sites could interact with the local MCP server via a victim's browser. Added a regression test case to verify that requests with malicious origins are blocked even when targeting localhost.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@codecov
Copy link

codecov bot commented Dec 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants