Merged
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| const PROJECT_CONFIG_FILENAME = 'btca.config.jsonc'; | ||
| const CONFIG_SCHEMA_URL = 'https://btca.dev/btca.schema.json'; | ||
| const CONFIG_SCHEMA_URL = 'https://btca.schema.json'; |
Contributor
There was a problem hiding this comment.
Schema URL is incorrect - missing domain.
Suggested change
| const CONFIG_SCHEMA_URL = 'https://btca.schema.json'; | |
| const CONFIG_SCHEMA_URL = 'https://btca.dev/btca.schema.json'; |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/cli/src/commands/init.ts
Line: 7:7
Comment:
Schema URL is incorrect - missing domain.
```suggestion
const CONFIG_SCHEMA_URL = 'https://btca.dev/btca.schema.json';
```
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
226
to
228
| export const initCommand = new Command('init') | ||
| .description('Initialize a btca project configuration') | ||
| .option('-l, --local', 'Use local .btca directory for data storage') | ||
| .description('Initialize btca for this project') | ||
| .option('-f, --force', 'Overwrite existing configuration') |
Contributor
There was a problem hiding this comment.
Breaking change: removed --local flag documented in CHANGELOG.md. Users expecting btca init --local will get errors.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/cli/src/commands/init.ts
Line: 226:228
Comment:
Breaking change: removed `--local` flag documented in CHANGELOG.md. Users expecting `btca init --local` will get errors.
How can I resolve this? If you propose a fix, please make it concise.
bmdavis419
force-pushed
the
davis/better-onboarding
branch
from
3f822a2 to
eb35f6d
Compare
|
|
||
| const PROJECT_CONFIG_FILENAME = 'btca.config.jsonc'; | ||
| const CONFIG_SCHEMA_URL = 'https://btca.dev/btca.schema.json'; | ||
| const CONFIG_SCHEMA_URL = 'https://btca.schema.json'; |
Contributor
There was a problem hiding this comment.
Schema URL is invalid - missing domain. Should be https://btca.dev/btca.schema.json (as it was before and as shown in btca.config.jsonc:2).
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/cli/src/commands/init.ts
Line: 7:7
Comment:
Schema URL is invalid - missing domain. Should be `https://btca.dev/btca.schema.json` (as it was before and as shown in `btca.config.jsonc:2`).
How can I resolve this? If you propose a fix, please make it concise.
Collaborator
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plan
onboarding stuff started
Greptile Overview
Greptile Summary
This PR refactors
btca initto offer two setup paths (MCP cloud vs CLI local), and adds a newbtca addcommand for interactively adding GitHub resources.Key Changes:
btca init --localflag with interactive prompt choosing between MCP or CLI setupbtca add <github-url>command with interactive wizardAGENTS.mdwith Better Context MCP instructionsINIT_MCP_CLI_REFACTOR_PLAN.mdplan fileCritical Issues:
--localflag frombtca initthat was documented inCHANGELOG.md. Users expectingbtca init --localwill get errors. The flag was replaced with an interactive prompt.https://btca.dev/btca.schema.jsontohttps://btca.schema.json(missing domain) inapps/cli/src/commands/init.ts:7, which will cause config validation to fail.INIT_MCP_CLI_REFACTOR_PLAN.mdshould be removed before merging.Confidence Score: 2/5
--localflag breaks existing functionality documented in CHANGELOG.md, and the invalid schema URL will cause config validation issuesapps/cli/src/commands/init.ts- it has a critical schema URL bug and breaking changesImportant Files Changed