007: add Wallet class for private key signing #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dawsbot
force-pushed
the
feat/007-wallet
branch
from
b9d55b3 to
9ba9c40
Compare
dawsbot
force-pushed
the
feat/007-wallet
branch
from
9ba9c40 to
85024da
Compare
Removes [axios](https://github.com/axios/axios). It's no longer used after updating ancestor dependencies [axios](https://github.com/axios/axios), [@docusaurus/core](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus) and [@docusaurus/preset-classic](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus-preset-classic). These dependencies need to be updated together. Removes `axios` Updates `@docusaurus/core` from 2.1.0 to 3.9.2 - [Release notes](https://github.com/facebook/docusaurus/releases) - [Changelog](https://github.com/facebook/docusaurus/blob/main/CHANGELOG-v2.md) - [Commits](https://github.com/facebook/docusaurus/commits/v3.9.2/packages/docusaurus) Updates `@docusaurus/preset-classic` from 2.1.0 to 3.9.2 - [Release notes](https://github.com/facebook/docusaurus/releases) - [Changelog](https://github.com/facebook/docusaurus/blob/main/CHANGELOG-v2.md) - [Commits](https://github.com/facebook/docusaurus/commits/v3.9.2/packages/docusaurus-preset-classic) --- updated-dependencies: - dependency-name: axios dependency-version: dependency-type: indirect - dependency-name: "@docusaurus/core" dependency-version: 3.9.2 dependency-type: direct:production - dependency-name: "@docusaurus/preset-classic" dependency-version: 3.9.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
- Wallet class with private key management and address derivation - signMessage following EIP-191 (personal_sign) standard - Address derivation using secp256k1 + keccak256 - publicKey getter, connect(provider) method - signTypedData placeholder (throws Not yet implemented) - Uses existing @noble/secp256k1 and @noble/hashes dependencies - 16 passing tests covering address derivation, signing, recovery, and edge cases
dawsbot
force-pushed
the
feat/007-wallet
branch
from
85024da to
3e8824e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Wallet class for private key management and message signing. Supports address derivation, signMessage (EIP-191 personal_sign), and lays groundwork for signTypedData and sendTransaction. Uses @noble/secp256k1 (already a dependency). Part of Phase 1 roadmap (Wallet & Signing - THE Big One).
What is included
Wallet class (
src/classes/Wallet.ts).addressgetter derives checksummed Ethereum address via secp256k1 + keccak256.publicKeygetter returns uncompressed public key (65 bytes, 04 prefix)signMessage(message)follows EIP-191 personal_sign standardsignTypedData()placeholder (throws Not yet implemented).connect(provider)attaches provider for future sendTransaction support16 tests (
src/classes/test/Wallet.test.ts)Dependencies
No new dependencies — uses existing
@noble/secp256k1and@noble/hashes.