Conversation
There was a problem hiding this comment.
There were a few updates to the Windows desktop app recently:
Can you double check if anything needs to be ported to Mac builds as well before starting to support them?
Also, while I think having a Mac build makes sense...I'm a bit wary of starting to support it without first considering these questions:
- What if a plugin includes a pipeline that won't run on Mac? How should that be handled?
- What if a plugin includes a pipeline that runs on Mac, but runs poorly? How should that be handled?
Curious if you have thoughts on this.
Yes, they will work fine:
IMO this is not a blocker for releasing the Electron app on macOS. However, it’s something we should consider more broadly in the context of plugins and environment compatibility. I see two scenarios:
2. Runtime failure
This isn’t macOS-specific. The same can happen on Windows without a GPU or with insufficient hardware. It’s a broader issue around clearly communicating plugin and pipeline requirements. Also, I expect the macOS Electron app to be used mostly with Cloud for now, since most demanding pipelines require a GPU anyway. |
66915b7 to
39d51e8
Compare
|
@leszko small request, should we get an icon with a transparent background? 🙂 I noticed it when I built the app locally. |
Will do tm! |
I think your points make sense. But, I'd like to double check that we've tested the installation and runtime failure scenarios before moving forward with supporting Mac releases. It's ok if certain plugins/pipelines don't work on Mac, but I'd like to verify that in the scenarios that you describe the installation/use of the plugins don't break the app installation for Mac users in a non-recoverable way (eg no way to get back to working install without needing to go into the CLI) as that would then become a pain to deal with support wise. |
39d51e8 to
d10f3a4
Compare
Ok, I actually like that you're pushing me to do more tests. I just discovered that the x64 can't work, because the torch wheels are not longer supported for Mac Intel Silicon. Therefore, removed the x64 builds. So, we'll distribute only arm64. Re: Testing plugins, I've spent some time today testing them. And I think we're good to go. Here's how it works:
The bottom line, is that installing/uninstalling plugins have not break the environment or anything. |
Signed-off-by: Rafał Leszko <rafal@livepeer.org>
d10f3a4 to
be58233
Compare
Summary
afterSignhook so the app passes Gatekeeper on user machinesupdate-latest-yml.jsto generatelatest-mac.ymlfor the macOS auto-updaterRelease artifacts
Each release will now include 2 additional macOS files:
DaydreamScope-arm64.dmgDaydreamScope-*-arm64.zipThe ZIP files are required because
electron-updateron macOS downloads ZIP archives (not DMGs) when performing in-app auto-updates.All files are signed with Apple Developer ID credentials and notarized, so users will not see Gatekeeper warnings.
Testing
Tested all features on macOS including pipelines, WebRTC streaming, settings, plugins, and the auto-updater — everything works correctly.