Conversation
c6c90fb to
9cffaf0
Compare
leszko
left a comment
There was a problem hiding this comment.
Nice work @thomshutt ! I really like how now the plugins start to be the central thing in Scope!
A few functional things (I tried to present in the demo recording):
- When you make the window wider, it would be maybe nice to make the dialog with plugins wider as well, becuase it looks squeezed even if you have a big screen. The same actually with the height, it could use more of the screen.
- The link from the plugin should go directly to the specific plugin, not the main plugin page
- After the plugin is installed it should be displayed as "Installed"; Currently after the server refresh, nothing changes
- Question: how to do you decide if the plugin is "tool" or "effect"? Do we have such distinction on the plugin page?
demo_plugins.mp4
| setError(null); | ||
| try { | ||
| const params = new URLSearchParams({ | ||
| limit: "50", |
There was a problem hiding this comment.
What if we have more than 50 entries? Should we have some pagination?
There was a problem hiding this comment.
There is pagination, the 50 is actually specifying how many per page
Great call, fixed and tested on my external monitor + Macbook. LMK what you think but it looks a lot better IMO.
Fixed
Fixed - it was missing a link between the installed plugins (Python packages) and the Discover tab. Matching on Github repo URL now.
This is self-defined in daydream.live but I think we'll get rid of it since it's not useful at the moment. I've removed from the UI |
Signed-off-by: Thom Shutt <thomshutt@users.noreply.github.com>
Signed-off-by: Thom Shutt <thomshutt@users.noreply.github.com>
Signed-off-by: Thom Shutt <thomshutt@users.noreply.github.com>
Signed-off-by: Thom Shutt <thomshutt@users.noreply.github.com>
Signed-off-by: Thom Shutt <thomshutt@users.noreply.github.com>
…ason Signed-off-by: Thom Shutt <thomshutt@users.noreply.github.com>
Signed-off-by: Thom Shutt <thomshutt@users.noreply.github.com>
Signed-off-by: Thom Shutt <thomshutt@users.noreply.github.com>
Signed-off-by: Thom Shutt <thomshutt@users.noreply.github.com>
25b4c0b to
fb909d1
Compare
leszko
left a comment
There was a problem hiding this comment.
Looks great. Thanks Thom!
Since we're seeing a lot of uptake of plugins, it makes sense to break them out to a top-level nav item rather than hiding within Settings.
Also implements plugin discovery within Scope, by calling the Daydream API.
Navbar:

Dialog:
