fix: strip .git suffix from plugin package_spec URLs#511
Open
livepeer-tessa wants to merge 2 commits intomainfrom
Open
fix: strip .git suffix from plugin package_spec URLs#511livepeer-tessa wants to merge 2 commits intomainfrom
livepeer-tessa wants to merge 2 commits intomainfrom
Conversation
Replace requestAnimationFrame + captureStream(fps) with setInterval + captureStream(0) + manual requestFrame(). This ensures canvas drawing only happens at the target FPS rate, eliminating the mismatch between ~60fps draws and lower-rate captures that caused 'GPU stall due to ReadPixels' warnings. Fixes #509
The web platform parses package_spec to construct GitHub API URLs (e.g., api.github.com/repos/owner/repo). When git_url contains a .git suffix, the API call fails with 404. Strip the suffix when building package_spec since it's not needed for pip/uv operations either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #508
Problem
The web platform at app.daydream.live/plugins parses
package_specfrom the plugin API to construct GitHub API URLs (e.g.,api.github.com/repos/owner/repo). When the git URL contains a.gitsuffix, the resulting API call (e.g.,repos/Shih-Yu/Spotify_Scope_Plugin.git) returns 404.Fix
Strip the
.gitsuffix fromgit_urlwhen constructingpackage_specin the plugin manager. The suffix is not needed for pip/uv install operations, and removing it ensures downstream consumers can safely parse the URL for GitHub API calls.Changes
src/scope/core/plugins/manager.py: Added.removesuffix('.git')when buildingpackage_specfrom git URLs