Skip to content

Fix null data in graphs JSON responses #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tire-fire wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix null data in graphs JSON responses #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions www/api/graphs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func GetServiceStatus(w http.ResponseWriter, r *http.Request) {
Data []Point
}

var series []Series
series := make([]Series, 0, len(teams))
for _, team := range teams {
temp := make(map[string]Point)
for _, uniqueName := range uniqueServices {
Expand All @@ -68,7 +68,7 @@ func GetServiceStatus(w http.ResponseWriter, r *http.Request) {
}
}

var points []Point
points := make([]Point, 0, len(temp))
for _, point := range temp {
points = append(points, point)
}
Expand Down Expand Up @@ -118,7 +118,7 @@ func GetScoreStatus(w http.ResponseWriter, r *http.Request) {
teams = slices.DeleteFunc(teams, func(team db.TeamSchema) bool { return !team.Active })

for _, team := range teams {
s := Series{Name: team.Name}
s := Series{Name: team.Name, Data: make([]Point, 0)}
series = append(series, s)
}

Expand Down Expand Up @@ -192,7 +192,7 @@ func GetUptimeStatus(w http.ResponseWriter, r *http.Request) {
for _, team := range teams {
s := Series{Name: team.Name}

var points []Point
points := make([]Point, 0, len(uniqueServices))
for _, servicename := range uniqueServices {
percentage := -0.01
for service, uptime := range uptime[team.ID] {
Expand Down