Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
==========================================
+ Coverage 78.27% 85.45% +7.18%
==========================================
Files 196 100 -96
Lines 17945 11382 -6563
Branches 2097 1323 -774
==========================================
- Hits 14046 9727 -4319
+ Misses 3348 1355 -1993
+ Partials 551 300 -251 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think when running multicore the check for folder existence should be done only on master job, otherwise every other job will raise the error. |
|
Just another thing, maybe we can add in the error message that the check can be skipped using --exist flag. |
|
No theses tests does not work in parallel with |
|
I'm also fine with skipping them under parallel and adding copies of them with the subprocess command being prepended with This could also be another improvement when we switch to |
Helveg
left a comment
There was a problem hiding this comment.
LGTM! Maybe think about my comment above, and perhaps for now just skip under parallel so we don't cause any weird flake, and write the remaining issues/improvements in an issue. I'm OK to merge this
|
I think I prefer the current implementation of the unittests because each step is captured by the coverage tool (we can see which lines were covered), while I could not make it work with |
Describe the work done
List which issues this resolves:
Close #204 #206
📚 Documentation preview 📚: https://bsb-nest--207.org.readthedocs.build/en/207/
📚 Documentation preview 📚: https://bsb-core--207.org.readthedocs.build/en/207/