fix: Caching morphology loaders during placement#208
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
==========================================
+ Coverage 78.23% 85.11% +6.87%
==========================================
Files 196 86 -110
Lines 17936 10875 -7061
Branches 2096 1280 -816
==========================================
- Hits 14033 9256 -4777
+ Misses 3350 1331 -2019
+ Partials 553 288 -265 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Helveg
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running placement strategy jobs, the user can use a distributor to generate morphologies on the fly, this will make the loading of the morphologies performed by each job longer the more morphologies are generated and stored.
The
pool_cachedecorator used to cache node properties across jobs of the same strategy does not work on the nodes stored as sub-class attributes.Work achieved
pool_cachedecorator to work with strategy node attributes (by visiting sub classes)List which issues this resolves:
Close #201 #202
📚 Documentation preview 📚: https://bsb-core--208.org.readthedocs.build/en/208/