Skip to content

fix: Caching morphology loaders during placement#208

Merged
drodarie merged 2 commits intomainfrom
fix/pool_cache
Dec 12, 2025
Merged

fix: Caching morphology loaders during placement#208
drodarie merged 2 commits intomainfrom
fix/pool_cache

Conversation

@drodarie
Copy link
Contributor

@drodarie drodarie commented Dec 6, 2025

Description

When running placement strategy jobs, the user can use a distributor to generate morphologies on the fly, this will make the loading of the morphologies performed by each job longer the more morphologies are generated and stored.
The pool_cache decorator used to cache node properties across jobs of the same strategy does not work on the nodes stored as sub-class attributes.

Work achieved

  • Cache the morphology loaders across similar placement strategy jobs.
  • Fix pool_cache decorator to work with strategy node attributes (by visiting sub classes)

List which issues this resolves:

Close #201 #202


📚 Documentation preview 📚: https://bsb-core--208.org.readthedocs.build/en/208/

@drodarie drodarie requested a review from Helveg December 6, 2025 11:12
@drodarie drodarie self-assigned this Dec 6, 2025
@github-actions github-actions bot added the fix label Dec 6, 2025
@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.11%. Comparing base (a8bfccf) to head (5cbc43e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
+ Coverage   78.23%   85.11%   +6.87%     
==========================================
  Files         196       86     -110     
  Lines       17936    10875    -7061     
  Branches     2096     1280     -816     
==========================================
- Hits        14033     9256    -4777     
+ Misses       3350     1331    -2019     
+ Partials      553      288     -265     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@drodarie drodarie merged commit 8ac06bf into main Dec 12, 2025
27 checks passed
@drodarie drodarie deleted the fix/pool_cache branch December 12, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_node_cache_items does not check recursively for cached items in sub-nodes attributes

2 participants