Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
+ Coverage 78.72% 85.09% +6.36%
==========================================
Files 196 122 -74
Lines 18171 12531 -5640
Branches 2142 1467 -675
==========================================
- Hits 14305 10663 -3642
+ Misses 3311 1536 -1775
+ Partials 555 332 -223 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Helveg
requested changes
Jan 28, 2026
Contributor
Helveg
left a comment
There was a problem hiding this comment.
Looks good! Double check what's going on with multi-sim, and multi-block.
- Add a test with a 1 sim that writes 3 blocks, and verify data goes into correct blocks
- Add a test with 3 sims that each write to 2-3 blocks and also verify integrity
- Add a test that tries to write 10G to disk and check that memory stays flat.
Comment on lines
+237
to
+238
| # else: | ||
| # result.write(root / f"{uuid4()}.nio", "ow") |
Contributor
There was a problem hiding this comment.
Suggested change
| # else: | |
| # result.write(root / f"{uuid4()}.nio", "ow") |
| self.name = simulation.name | ||
| io = io.NixIO(filename, mode="rw") | ||
| io.write(Block(name=self.name, nix_name=self.name, config=tree)) | ||
| for i, nixblock in enumerate(io.nix_file.blocks): |
Contributor
There was a problem hiding this comment.
something seems off here, only 1 block id is ever stored, so it seems like everything will write to the first block?
each simulation should write to their own block inside the same file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the work done
Add a fix to the simulation checkpoint integration, since it is the expected behavior. Now when results are flushed they are written to file without storing memory. As discussed backward compatibility is preserved, the new behavior is triggered only when
run_simulationmethod is called specifyingoutput_filenameargument, this will be the default when CLI is used.Refer to issue: #50
Tasks
📚 Documentation preview 📚: https://bsb-nest--213.org.readthedocs.build/en/213/
📚 Documentation preview 📚: https://bsb-neuron--213.org.readthedocs.build/en/213/
📚 Documentation preview 📚: https://bsb-core--213.org.readthedocs.build/en/213/