Open
Conversation
dbeef
commented
Sep 5, 2021
dbeef
commented
Sep 5, 2021
| ) | ||
|
|
||
| target_compile_definitions( | ||
| GameLoop PRIVATE $<IF:$<BOOL:${SPELUNKY_PSP_BENCHMARK_MODE}>,SPELUNKY_PSP_BENCHMARK_MODE,> |
Owner
Author
There was a problem hiding this comment.
As mentioned in description, still not sure whether to make benchmarking a build option or a commandline argument.
dbeef
commented
Sep 5, 2021
dbeef
commented
Sep 5, 2021
dbeef
commented
Sep 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still not sure whether to make benchmarking a special build option, or trigger it by passing a flag.
First one would cut unused code from the final binary and shorten build time by a little (because how often do you do benchmarking?). Additionally, code for benchmarking may simply not compile on some platforms (using filesystem).
The latter has the benefit of benchmarking without making a special build.
Moving benchmarking out into a separate target probably makes sense.
Benchmarking as a form of acceptance test done on CI doesn't make sense, because even if software-implemented OpenGL drivers are available in utilized Docker image, the same CPU time / hardware can't be asserted on each bulid so the FPS will vary significantly.