Implement settings persistence for the settings server #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created an API server for settings on port 8001 - Updated the React app to use the API for fetching and saving settings - Added the API server to supervisord.conf - Settings are persisted in Redis and used by the main application 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Modified the API server to also serve static files from the settings-server/dist directory - Removed the separate settings-server process from supervisord.conf - Updated the React app to use relative API paths instead of hard-coded URLs - Simplified the architecture by using a single server on port 8000 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Added demo settings initialization when none exist - Improved handling of default template values - Added debugging information in server logs - Enhanced React app to filter out empty/undefined values - Added more robust error handling 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Removed demo settings initialization function - Improved the logic for filtering out template placeholder values - Adjusted debug logging to be more informative 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Improved template value detection to properly check for placeholder values - Fixed settings inclusion logic in the API response to include all valid settings - Modified React app to handle all settings values consistently - Fixed indentation in API server code - Added more logging to help track down issues 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Added test settings initialization to seed Redis with sample settings - Added detailed debug logging to trace the data flow - Added a debug endpoint to check settings directly - Added a hidden debug element to visualize the app state - Improved template value detection and handling 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Removed debug logging - Removed test setting initialization - Removed debug endpoint - Removed debug UI elements - Cleaned up whitespace and formatting - Simplified the code for better maintainability 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Added a /api/reset endpoint to clear test settings from Redis - Specifically targets CUSTOM_COMMAND_PATHS that was added during testing - Provides a way to clean up test data without direct Redis access 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Removed the sys.path.insert line since the project is properly structured as a package - The import statements already use absolute imports from the gonotego package - This simplifies the code without affecting functionality 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Merged the functionality of api_server.py and runner.py into a single server.py file - Updated supervisord.conf to use the new server.py file - This simplifies the codebase by reducing the number of files - No functional changes to the implementation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Removed files that have been consolidated into server.py - Keeps the codebase clean by eliminating redundant files 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Removed unused import urllib.parse.parse_qs - Removed unused import gonotego.common.interprocess - The settings module already manages Redis interactions internally 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementation Details
Test plan
make it so that when save in the settings server is clicked, the settings are persisted and those settings are used by the Go Note Go main application; keep this PR as small as possible to get it working
🤖 Generated with Claude Code