Skip to content

Fix: Handle max retries in awaitWorkflowResult #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix: Handle max retries in awaitWorkflowResult #190

wants to merge 5 commits into from

Conversation

@vr-varad
Copy link
Contributor

@vr-varad vr-varad commented Nov 18, 2025 •
edited
Loading

Fixes #143

@vr-varad
Copy link
Contributor Author

vr-varad commented Nov 18, 2025

@maxdml Kindly review at your convenience.
Would you like me to add tests as well?

@maxdml
Copy link
Collaborator

maxdml commented Nov 20, 2025 •
edited
Loading

@maxdml Kindly review at your convenience. Would you like me to add tests as well?

Thanks Varad, yes let's fix the TestWorkflowQueues/QueueWorkflowDLQ test. All the handles calls to GetResult should yield the max retries error now. (Because the mere fact of attempting to recover the workflow moves it to the DLQ and sets the error.)

vr-varad
vr-varad commented Nov 21, 2025
View reviewed changes
dbos/queues_test.go
result, err := handle.GetResult()
require.NoError(t, err, "failed to get result from recovered workflow handle")
assert.Equal(t, "test-input", result, "expected result to be 'test-input'")
result, _ := handle.GetResult()
Copy link
Contributor Author

@vr-varad vr-varad Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxdml I made changes in the test, but I am not sure how to handle result err.

Copy link
Collaborator

@maxdml maxdml Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to type assert it into a DBOSError and then you can check it's Is method with the new error code.

We don't care about the result, we're just interested in checking the error. All the handles should return an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxdml maxdml maxdml left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle max retries in awaitWorkflowResult

2 participants

@vr-varad @maxdml