Chore update shacl tests coverage table#829
Conversation
📝 WalkthroughWalkthroughThe PR consolidates server configuration management by eliminating CI-specific configuration files. It removes separate Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
dump/src/test/resources/shaclTestsCoverageTable.md (1)
29-176: Fix rows missing columns (markdownlint MD055/MD056).Several updated rows only include the first column and a trailing pipe, so the 4‑column table becomes malformed. Ensure each row has four cells (use empty placeholders for missing values) and avoid trailing pipes.
✅ Example row fix (apply same pattern to other affected rows)
-[http://de.dbpedia.org/resource/Arthur_Schopenhauer](http://dief.tools.dbpedia.org/server/extraction/de/extract?title=Arthur_Schopenhauer&revid=&format=trix&extractors=custom) | +[http://de.dbpedia.org/resource/Arthur_Schopenhauer](http://dief.tools.dbpedia.org/server/extraction/de/extract?title=Arthur_Schopenhauer&revid=&format=trix&extractors=custom) | | |Also applies to: 220-259
🧹 Nitpick comments (2)
server/server.default.properties (1)
21-23: Confirm the broader default language list is intended outside CI.This expands the default server scope for all environments, not just CI. If the intent is CI-only, consider keeping a minimal default here and applying the expanded list via a CI-specific override to avoid unintended resource impact in non-CI runs.
.github/workflows/long-running-extraction-tests.yml (1)
39-45: Avoid duplicating the long languages list in CI.The workflow now rewrites
server.default.propertiesto the same list already committed, which risks drift and adds maintenance overhead. Consider relying on the file as the single source of truth and drop the sed step.♻️ Proposed cleanup (remove redundant override)
- # TODO: fi,et,lt are causing issues, i.e. NoSuchElementException: no mapping namespace for language fi - # sed -i 's/^languages=.*/languages=wikidata,en,de,fr,es,it,pt,ru,ja,ko,ar,hi,nl,sv,pl,uk,cs,sk,sl,sr,hr,ro,bg,hu,tr,el,fi,et,lv,lt,ga,cy,eo,ca,gl,eu,be,az,hy,am,bn,ur,vi,id,mk,commons/' server.default.properties - - name: Create temporary server config with languages (CI-only) - run: | - cd server - sed -i 's/^languages=.*/languages=wikidata,en,de,fr,es,it,pt,ru,ja,ko,ar,hi,nl,sv,pl,uk,cs,sk,sl,sr,hr,ro,bg,hu,tr,el,lv,ga,cy,eo,ca,gl,eu,be,az,hy,am,bn,ur,vi,id,mk,commons/' server.default.properties
| @@ -18,7 +18,9 @@ ontology=../ontology.xml | |||
| mappings=../mappings | |||
|
|
|||
| # List of languages, e.g. 'en,de,fr' or '@mappings' | |||
There was a problem hiding this comment.
| # List of languages, e.g. 'en,de,fr' or '@mappings' | |
| # List of languages, e.g., 'en,de,fr' or '@mappings' |
| @@ -121,22 +123,22 @@ wikipage-uri|shacl-test|issue|comment | |||
| [http://en.dbpedia.org/resource/IKEA](http://dief.tools.dbpedia.org/server/extraction/en/extract?title=IKEA&revid=&format=trix&extractors=custom) | [http://dbpedia.org/property/work](http://dbpedia.org/property/work) #Citation_english_language_work_datatype_validation | | |||
| [http://en.dbpedia.org/resource/IKEA](http://dief.tools.dbpedia.org/server/extraction/en/extract?title=IKEA&revid=&format=trix&extractors=custom) | [http://dbpedia.org/property/year](http://dbpedia.org/property/year) #Citation_english_languagа_year_datatype_validation | | |||
| [http://en.dbpedia.org/resource/IKEA](http://dief.tools.dbpedia.org/server/extraction/en/extract?title=IKEA&revid=&format=trix&extractors=custom) | [http://dbpedia.org/resource/IKEA](http://dbpedia.org/resource/IKEA) #IKEA | [https://github.com/dbpedia/extraction-framework/issues/630](https://github.com/dbpedia/extraction-framework/issues/630) | no company type for some specific entities (e.g. IKEA; Samsung) | | |||
There was a problem hiding this comment.
| [http://en.dbpedia.org/resource/IKEA](http://dief.tools.dbpedia.org/server/extraction/en/extract?title=IKEA&revid=&format=trix&extractors=custom) | [http://dbpedia.org/resource/IKEA](http://dbpedia.org/resource/IKEA) #IKEA | [https://github.com/dbpedia/extraction-framework/issues/630](https://github.com/dbpedia/extraction-framework/issues/630) | no company type for some specific entities (e.g. IKEA; Samsung) | | |
| [http://en.dbpedia.org/resource/IKEA](http://dief.tools.dbpedia.org/server/extraction/en/extract?title=IKEA&revid=&format=trix&extractors=custom) | [http://dbpedia.org/resource/IKEA](http://dbpedia.org/resource/IKEA) #IKEA | [https://github.com/dbpedia/extraction-framework/issues/630](https://github.com/dbpedia/extraction-framework/issues/630) | no company type for some specific entities (e.g., IKEA, Samsung) | |
| @@ -156,20 +158,22 @@ wikipage-uri|shacl-test|issue|comment | |||
| [http://en.dbpedia.org/resource/Samsung](http://dief.tools.dbpedia.org/server/extraction/en/extract?title=Samsung&revid=&format=trix&extractors=custom) | [http://dbpedia.org/resource/Samsung](http://dbpedia.org/resource/Samsung) #Samsung | [https://github.com/dbpedia/extraction-framework/issues/630](https://github.com/dbpedia/extraction-framework/issues/630) | no company type for some specific entities (e.g. IKEA; Samsung) | | |||
There was a problem hiding this comment.
| [http://en.dbpedia.org/resource/Samsung](http://dief.tools.dbpedia.org/server/extraction/en/extract?title=Samsung&revid=&format=trix&extractors=custom) | [http://dbpedia.org/resource/Samsung](http://dbpedia.org/resource/Samsung) #Samsung | [https://github.com/dbpedia/extraction-framework/issues/630](https://github.com/dbpedia/extraction-framework/issues/630) | no company type for some specific entities (e.g. IKEA; Samsung) | | |
| [http://en.dbpedia.org/resource/Samsung](http://dief.tools.dbpedia.org/server/extraction/en/extract?title=Samsung&revid=&format=trix&extractors=custom) | [http://dbpedia.org/resource/Samsung](http://dbpedia.org/resource/Samsung) #Samsung | [https://github.com/dbpedia/extraction-framework/issues/630](https://github.com/dbpedia/extraction-framework/issues/630) | no company type for some specific entities (e.g., IKEA, Samsung) | |
|
@TallTed this is just to see from where the automatic changes came (GitHub Action). This PR will be closed without merging. |
|
Result of investigation: no changes by the |



Hi @TallTed
Just want to see what the
minidumpdoc.ymlaction will do to this PR.Summary by CodeRabbit
Release Notes
Configuration
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.