Skip to content

Chore update shacl tests coverage table#829

Closed
Integer-Ctrl wants to merge 3 commits intomasterfrom
chore-update-shaclTestsCoverageTable
Closed

Chore update shacl tests coverage table#829
Integer-Ctrl wants to merge 3 commits intomasterfrom
chore-update-shaclTestsCoverageTable

Conversation

@Integer-Ctrl
Copy link
Contributor

@Integer-Ctrl Integer-Ctrl commented Jan 27, 2026

Hi @TallTed

Just want to see what the minidumpdoc.yml action will do to this PR.

Summary by CodeRabbit

Release Notes

  • Configuration

    • Expanded server language support to cover 30+ languages globally, including Spanish, Italian, Portuguese, Russian, Japanese, Korean, Arabic, Hindi, Dutch, Swedish, Polish, Ukrainian, Czech, and additional regional languages.
  • Documentation

    • Updated test coverage documentation.
  • Chores

    • Simplified deployment process and configuration management for server startup.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

📝 Walkthrough

Walkthrough

The PR consolidates server configuration management by eliminating CI-specific configuration files. It removes separate server.ci.properties usage from CI workflows and the redeploy-server script, instead directly configuring languages in server.default.properties. Test coverage documentation is also updated with revised table entries.

Changes

Cohort / File(s) Summary
CI/Server Configuration
.github/workflows/long-running-extraction-tests.yml, redeploy-server, server/server.default.properties
Removed CI-specific server configuration workflow. Consolidated language configuration into server.default.properties instead of creating separate CI-specific files. Updated language list to include expanded set (es, it, pt, ru, ja, ko, ar, hi, nl, sv, pl, uk, cs, sk, sl, sr, hr, ro, bg, hu, tr, el, lv, ga, cy, eo, ca, gl, eu, be, az, hy, am, bn, ur, vi, id, mk, commons). Added TODO comment regarding fi, et, lt causing issues.
Test Documentation
dump/src/test/resources/shaclTestsCoverageTable.md
Updated table entries with revised resource rows, some adding GitHub issue links and commentary.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • JJ-Author
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title 'Chore update shacl tests coverage table' only partially aligns with the changeset. While it mentions updating the SHACL tests coverage table, the PR also contains significant changes to CI workflows, server configuration, and language settings that are not reflected in the title. Consider a more comprehensive title that captures the main changes, such as 'Fix server configuration and update SHACL tests coverage table' or provide clarification on the primary objective of these changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore-update-shaclTestsCoverageTable

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
dump/src/test/resources/shaclTestsCoverageTable.md (1)

29-176: Fix rows missing columns (markdownlint MD055/MD056).

Several updated rows only include the first column and a trailing pipe, so the 4‑column table becomes malformed. Ensure each row has four cells (use empty placeholders for missing values) and avoid trailing pipes.

✅ Example row fix (apply same pattern to other affected rows)
-[http://de.dbpedia.org/resource/Arthur_Schopenhauer](http://dief.tools.dbpedia.org/server/extraction/de/extract?title=Arthur_Schopenhauer&revid=&format=trix&extractors=custom) | 
+[http://de.dbpedia.org/resource/Arthur_Schopenhauer](http://dief.tools.dbpedia.org/server/extraction/de/extract?title=Arthur_Schopenhauer&revid=&format=trix&extractors=custom) |  |  | 

Also applies to: 220-259

🧹 Nitpick comments (2)
server/server.default.properties (1)

21-23: Confirm the broader default language list is intended outside CI.

This expands the default server scope for all environments, not just CI. If the intent is CI-only, consider keeping a minimal default here and applying the expanded list via a CI-specific override to avoid unintended resource impact in non-CI runs.

.github/workflows/long-running-extraction-tests.yml (1)

39-45: Avoid duplicating the long languages list in CI.

The workflow now rewrites server.default.properties to the same list already committed, which risks drift and adds maintenance overhead. Consider relying on the file as the single source of truth and drop the sed step.

♻️ Proposed cleanup (remove redundant override)
-    # TODO: fi,et,lt are causing issues, i.e. NoSuchElementException: no mapping namespace for language fi
-    # sed -i 's/^languages=.*/languages=wikidata,en,de,fr,es,it,pt,ru,ja,ko,ar,hi,nl,sv,pl,uk,cs,sk,sl,sr,hr,ro,bg,hu,tr,el,fi,et,lv,lt,ga,cy,eo,ca,gl,eu,be,az,hy,am,bn,ur,vi,id,mk,commons/' server.default.properties
-    - name: Create temporary server config with languages (CI-only)
-      run: |
-        cd server
-        sed -i 's/^languages=.*/languages=wikidata,en,de,fr,es,it,pt,ru,ja,ko,ar,hi,nl,sv,pl,uk,cs,sk,sl,sr,hr,ro,bg,hu,tr,el,lv,ga,cy,eo,ca,gl,eu,be,az,hy,am,bn,ur,vi,id,mk,commons/' server.default.properties

@@ -18,7 +18,9 @@ ontology=../ontology.xml
mappings=../mappings

# List of languages, e.g. 'en,de,fr' or '@mappings'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# List of languages, e.g. 'en,de,fr' or '@mappings'
# List of languages, e.g., 'en,de,fr' or '@mappings'

@@ -121,22 +123,22 @@ wikipage-uri|shacl-test|issue|comment
[http://en.dbpedia.org/resource/IKEA](http://dief.tools.dbpedia.org/server/extraction/en/extract?title=IKEA&revid=&format=trix&extractors=custom) | [http://dbpedia.org/property/work](http://dbpedia.org/property/work) #Citation_english_language_work_datatype_validation |
[http://en.dbpedia.org/resource/IKEA](http://dief.tools.dbpedia.org/server/extraction/en/extract?title=IKEA&revid=&format=trix&extractors=custom) | [http://dbpedia.org/property/year](http://dbpedia.org/property/year) #Citation_english_languagа_year_datatype_validation |
[http://en.dbpedia.org/resource/IKEA](http://dief.tools.dbpedia.org/server/extraction/en/extract?title=IKEA&revid=&format=trix&extractors=custom) | [http://dbpedia.org/resource/IKEA](http://dbpedia.org/resource/IKEA) #IKEA | [https://github.com/dbpedia/extraction-framework/issues/630](https://github.com/dbpedia/extraction-framework/issues/630) | no company type for some specific entities (e.g. IKEA; Samsung) |
Copy link
Contributor

@TallTed TallTed Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[http://en.dbpedia.org/resource/IKEA](http://dief.tools.dbpedia.org/server/extraction/en/extract?title=IKEA&revid=&format=trix&extractors=custom) | [http://dbpedia.org/resource/IKEA](http://dbpedia.org/resource/IKEA) #IKEA | [https://github.com/dbpedia/extraction-framework/issues/630](https://github.com/dbpedia/extraction-framework/issues/630) | no company type for some specific entities (e.g. IKEA; Samsung) |
[http://en.dbpedia.org/resource/IKEA](http://dief.tools.dbpedia.org/server/extraction/en/extract?title=IKEA&revid=&format=trix&extractors=custom) | [http://dbpedia.org/resource/IKEA](http://dbpedia.org/resource/IKEA) #IKEA | [https://github.com/dbpedia/extraction-framework/issues/630](https://github.com/dbpedia/extraction-framework/issues/630) | no company type for some specific entities (e.g., IKEA, Samsung) |

@@ -156,20 +158,22 @@ wikipage-uri|shacl-test|issue|comment
[http://en.dbpedia.org/resource/Samsung](http://dief.tools.dbpedia.org/server/extraction/en/extract?title=Samsung&revid=&format=trix&extractors=custom) | [http://dbpedia.org/resource/Samsung](http://dbpedia.org/resource/Samsung) #Samsung | [https://github.com/dbpedia/extraction-framework/issues/630](https://github.com/dbpedia/extraction-framework/issues/630) | no company type for some specific entities (e.g. IKEA; Samsung) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[http://en.dbpedia.org/resource/Samsung](http://dief.tools.dbpedia.org/server/extraction/en/extract?title=Samsung&revid=&format=trix&extractors=custom) | [http://dbpedia.org/resource/Samsung](http://dbpedia.org/resource/Samsung) #Samsung | [https://github.com/dbpedia/extraction-framework/issues/630](https://github.com/dbpedia/extraction-framework/issues/630) | no company type for some specific entities (e.g. IKEA; Samsung) |
[http://en.dbpedia.org/resource/Samsung](http://dief.tools.dbpedia.org/server/extraction/en/extract?title=Samsung&revid=&format=trix&extractors=custom) | [http://dbpedia.org/resource/Samsung](http://dbpedia.org/resource/Samsung) #Samsung | [https://github.com/dbpedia/extraction-framework/issues/630](https://github.com/dbpedia/extraction-framework/issues/630) | no company type for some specific entities (e.g., IKEA, Samsung) |

@Integer-Ctrl
Copy link
Contributor Author

@TallTed this is just to see from where the automatic changes came (GitHub Action). This PR will be closed without merging.

@Integer-Ctrl
Copy link
Contributor Author

Result of investigation: no changes by the minidumpdoc.yml action do to this PR.

@Integer-Ctrl Integer-Ctrl deleted the chore-update-shaclTestsCoverageTable branch January 29, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants