Skip to content

Conversation

@driesdesmet
Copy link
Contributor

I've started implementing multiple quotes, but I have trouble migrating existing plugins. You can find an attempt here: https://gist.github.com/driesdesmet/8d1eed9f7a64167a6bbd
but I get ‘must be a "CMSPlugin" instance’.

I think I need some help here, unless it's decided that the data migration is not needed.

@driesdesmet
Copy link
Contributor Author

@dbrgn Are you still interested in maintaining this plugin? I'd consider forking it under a different name: eg "cmsplugin-quote" and generalise it so a non-random quote would also be a possibility. Since a lot has changed with the 3.x versions of django-cms, a fork would also help to squash the migrations and drop South support. The idea would be to let divio know about this plugin, so a link on their 'add-on' page could list it.
So, there is probably 2 options here: either a new release of this plugin with backwards incompatible changes, or just leave this version be and use your base to further develop a new plugin. From what I understand from a previous comment, you're not using django-cms anymore, but I would welcome your blessing/support/help.

@dbrgn
Copy link
Owner

dbrgn commented Nov 24, 2015

Hi @driesdesmet. Sorry, I somehow missed your pull request.

If you want, I can also add you to the repository contributors or even transfer it to your account, I don't use the plugin myself anymore.

@driesdesmet
Copy link
Contributor Author

Hi,

no problem. That's very kind. I'm currently leaning more towards leaving
your repo 'as-is' for backwards compatibility. People might have your url
in their requirements file and so on, and transferring the code to my
account would change the url I believe. If you're okay with this, I'll
start a new project on github, name it cmsplugin-quote, keeping the history
of your commits and point to your repo from the README if people want the
<Django1.7 version.

On 24 November 2015 at 14:35, Danilo Bargen notifications@github.com
wrote:

Hi @driesdesmet https://github.com/driesdesmet. Sorry, I somehow missed
your pull request.

If you want, I can also add you to the repository contributors or even
transfer it to your account, I don't use it anymore.


Reply to this email directly or view it on GitHub
#8 (comment)
.

Dries Desmet

URGA | creatieve communicatie

Zuiderlaan 69
8790 Waregem
t 056 61 41 94
m 0477 19 41 13
dries@urga.be
www.urga.be

@dbrgn
Copy link
Owner

dbrgn commented Nov 24, 2015

no problem. That's very kind. I'm currently leaning more towards leaving
your repo 'as-is' for backwards compatibility.

Yeah, that might make sense. I'll link to that fork from my README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants