Typo on the instructions #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase_migrations' but should be 'base_migration'.
…t is not found in cache or via API the progress will not be incremented.
Contributor
Author
|
Moved progress bar increment to before a symbol is processed, as if it is not found in cache or via API the progress will not be incremented. |
…object when only '{ }' returned.
Contributor
Author
|
Last commit if for an additional error handling specifically for a failed deserialization of an object when only '{ }' returned. It doesn't affected the execution of code, but means the logs are clearer (IMHO). Tested all possible loaders to see if it has wider impact, it does not. |
dbrowne
approved these changes
Nov 23, 2025
dbrowne
approved these changes
Nov 23, 2025
dbrowne
approved these changes
Nov 23, 2025
Owner
|
merge approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typo on the directory name of the base_migration folder; stated as 'base_migrations' but should be 'base_migration'.