Add anchor links for individual columns#577
Open
xinkent wants to merge 3 commits intodbt-labs:mainfrom
Open
Conversation
Resolves dbt-labs#186 Each column row now has an HTML id attribute (`column-<name>`) and a clickable `#` link that appears on hover. Clicking the link updates the URL hash so the link can be shared. When navigating to a URL that contains a `#column-<name>` fragment the matching column is automatically expanded and scrolled into view via `$anchorScroll`. The feature applies to all pages that use the `column-details` directive (model, source, seed, snapshot).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #186
Description
Add anchor links for individual columns in the column details table, as requested in dbt-labs/dbt-docs#186.
Each column row now has an HTML
idattribute (column-<name>) and a clickable#link that appears on hover. Clicking the link updates the URL hash (e.g.#!/model/model.my_model#column-customer_id) so it can be shared. When navigating to a URL with a#column-<name>fragment, the matching column is automatically expanded and scrolled into view via$anchorScroll.This applies to all pages using the
column-detailsdirective: model, source, seed, and snapshot.Changes:
src/app/components/column_details/column_details.html— Addedidattribute to column rows, anchor link element, and hover CSSsrc/app/components/column_details/column_details.js— Addedcolumn_anchor()click handler,$watchonmodel.columnsfor auto-expand and scroll on page loadChecklist
changie newto create a changelog entry