Skip to content

fix to make drop_schema_name usable and test pass #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix to make drop_schema_name usable and test pass #563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dbt/include/sqlserver/macros/adapter/schemas.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

{% macro sqlserver__drop_schema_named(schema_name) %}
{% set schema_relation = api.Relation.create(schema=schema_name) %}
{% set schema_relation = api.Relation.create(schema=schema_name, database=target.database) %}
{{ adapter.drop_schema(schema_relation) }}
{% endmacro %}
8 changes: 0 additions & 8 deletions tests/functional/adapter/dbt/test_relations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import pytest
from dbt.tests.adapter.relations.test_changing_relation_type import BaseChangeRelationTypeValidator
from dbt.tests.adapter.relations.test_dropping_schema_named import BaseDropSchemaNamed

Expand All @@ -7,12 +6,5 @@ class TestChangeRelationTypeValidator(BaseChangeRelationTypeValidator):
pass


@pytest.mark.xfail(
reason="""
Test fails as its not passing Use[] properly.
`Use[None]` is called, should be `User[TestDB]`
Unclear why the macro doens't pass it properly.
"""
)
class TestDropSchemaNamed(BaseDropSchemaNamed):
pass