-
Notifications
You must be signed in to change notification settings - Fork 38
Porting to the Qt 6 framework and fixing some errors. #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GAlexDark
wants to merge
40
commits into
dbzhang800:master
Choose a base branch
from
GAlexDark:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using typedef-name 'using QStringList = class QList<QString>' after 'class'
Port QDateTime::fromTime_t() (deprecated) to QDateTime::fromSecsSinceEpoch(time_t)
Member variable 'MceXmlElementStateData::extensionElements' is not assigned in the copy constructor. Member variable 'MceXmlElementStateData::namespacePrefixes' is not assigned in the copy constructor.
Parameter 'transitional' is passed by value.
Parameter 'type' is passed by value.
Member variable 'XmlStreamReaderPrivate::extensionElementDepth' is not initialized in the constructor.
Parameter 'type' is passed by value.
Member variable 'LargeDocumentWriterPrivate::package' is not initialized in the constructor.
Member variable 'ZipPackagePartPrivate::zipArchive' is not initialized in the constructor.
Member variable 'LargeDocumentReaderPrivate::package' is not initialized in the constructor.
Port QFontMetrics::width() (obsolete) to QFontMetrics::horizontalAdvance()
Port QWheelEvent::delta() (obsolete) to QWheelEvent::pixelDelta()::y()
Port QWheelEvent::delta() (obsolete) to QWheelEvent::angleDelta()::y()
Port QString::SkipEmptyParts (obsolete) to Qt::SkipEmptyParts
The 'm_cursorPosition + 1' value is implicitly cast to the bool type.
The member of a class m_pixmapItem are not initialized inside the constructor
A part of conditional expression is always true: data.constData().
The members of a class 'result', 'filter' are not initialized inside the constructor.
The 'd->m_currentFile' pointer was utilized before it was verified against nullptr.
It's probably better to use a comparison with defined precision or use special functions.
It's probably better to use a comparison with defined precision or use special functions.
Add commands for Windows Qt MINGW and MSVC
Fix error: unknown type name 'QDateTime' [clang-diagnostic-error]
warning: enumeration value 'PE_ContentType' not handled in switch [- Wswitch] Maybe this enumeration value must be here
This reverts commit 2cb5f3d.
It's probably better to use a comparison with defined precision or use special functions. Fixed me error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I ported the project to the Qt 6 framework and fixed some errors that caused the project not to build in this framework.
Also, I am fixed my two errors.