Made dslforum version, works with Huawei Hg658c and other Huawei devices (probably)#1
Open
jsharp6968 wants to merge 1 commit intodc414:masterfrom
Open
Made dslforum version, works with Huawei Hg658c and other Huawei devices (probably)#1jsharp6968 wants to merge 1 commit intodc414:masterfrom
jsharp6968 wants to merge 1 commit intodc414:masterfrom
Conversation
ngharo
requested changes
Oct 28, 2019
Member
ngharo
left a comment
ngharo
left a comment
There was a problem hiding this comment.
Spotted a couple issues.
Thanks for taking the time to submit a PR!
| @@ -1,3 +1,4 @@ | |||
| """Adapted the code to make a Huawei version that uses dslforum schemas""" | |||
| #!/bin/python | |||
| res = res.replace("\n", ""); | ||
| res = res.replace("\t", ""); | ||
| pres = res.split("<serviceId>urn:upnp-org:serviceId:WANIPConn1</serviceId>"); | ||
| pres = res.split("<serviceId>urn:dslforum-org:serviceId:WANIPConn1</serviceId>"); |
Member
There was a problem hiding this comment.
Might be better to try both or make it configurable. While you're adding support for your devices, it probably is breaking support for the others.
| ctrl = p3res[1]; | ||
| open_ports = urllib2.Request("http://"+rhost[1]+""+ctrl, opmsg); | ||
| open_ports.add_header("SOAPACTION", '"urn:schemas-upnp-org:service:WANIPConnection:1#GetGenericPortMappingEntry"'); | ||
| open_ports.add_header("SOAPACTION", '"urn:dslforum-org :service:WANIPConnection:1#GetGenericPortMappingEntry"'); |
Member
|
Thanks for the PR! I agree with ngharo, "Might be better to try both or
make it configurable. While you're adding support for your devices, it
probably is breaking support for the others."
…On Mon, Oct 28, 2019 at 5:20 PM ngharo ***@***.***> wrote:
@ngharo <https://github.com/ngharo> requested your review on: #1
<#1> Made dslforum version,
works with Huawei Hg658c and other Huawei devices (probably).
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1?email_source=notifications&email_token=AA7IILC4UGWSVAYZDLR4TL3QQ5QULA5CNFSM4JFRQWX2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUPWXQOI#event-2750249017>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7IILC3AV47PXMBJJSD5ALQQ5QULANCNFSM4JFRQWXQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.