refactor(workspace, cli): decouple ephemeral conversation cleanup #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the cleanup of ephemeral conversations from the `persist` method in `Workspace` to a dedicated `remove_ephemeral_conversations` method. This new method is then explicitly called within the CLI after a task execution finishes. This change ensures that ephemeral conversations are not prematurely deleted during intermediate state persistence calls, providing better control over their lifecycle within the workspace. Signed-off-by: Jean Mertz <git@jeanmertz.com>
JeanMertz
force-pushed
the
improve-tool-inquery47
branch
from
a1c031a to
a0f3ef1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the cleanup of ephemeral conversations from the
persistmethod inWorkspaceto a dedicatedremove_ephemeral_conversationsmethod. This new method is then explicitly called within the CLI after a task execution finishes.This change ensures that ephemeral conversations are not prematurely deleted during intermediate state persistence calls, providing better control over their lifecycle within the workspace.