Support multiline alert log in integrator messages#3
Open
jmpesp wants to merge 7 commits intodcid:masterfrom
Open
Support multiline alert log in integrator messages#3jmpesp wants to merge 7 commits intodcid:masterfrom
jmpesp wants to merge 7 commits intodcid:masterfrom
Conversation
`sh` supports multiline variables like so:
variable='test
data
multiline'
Fill the alertlog integrator variable using every line of alert log. not
just the first one.
Existing integrations use a shell script to POST data and a previous commit changed the `alertlog` variable so it contains the full multiline alert log. This requires each line to be sanitized, otherwise the shell variable definition will be incorrect. Iterate over log output and sanitize each line. In the Slack integration, `curl` has been changed to use `--data-binary` so it will _not_ strip out newlines and carriage returns when POSTing data.
Number of open ports in netstat output is unusually large on our instances so bump up the log_size limit.
jmpesp
force-pushed
the
support_multiline_alert_log_in_integrator_messages
branch
from
49839cf to
a6d545d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fill the alertlog integrator variable using every line of alert log, not just the first one.
Also increases log limit sizes.