Switch to a _raw_ download to allow automated download#36
Open
BenjaminHCCarr wants to merge 1 commit intodcppc:masterfrom
BenjaminHCCarr:patch-1
Open
Switch to a _raw_ download to allow automated download#36BenjaminHCCarr wants to merge 1 commit intodcppc:masterfrom BenjaminHCCarr:patch-1
BenjaminHCCarr wants to merge 1 commit intodcppc:masterfrom
BenjaminHCCarr:patch-1
Conversation
Changing: https://github.com/dcppc/crosscut-metadata/blob/master/make-crosscut-instance-bdbag.sh to https://raw.githubusercontent.com/dcppc/crosscut-metadata/master/make-crosscut-instance-bdbag.sh Allows a curl/wget of this needed script.
Contributor
|
Hi Ben! This particular script isn't much use without the rest of the code in the repo and if someone does a git clone (or downloads any of the releases) to obtain that code they will also get a copy of the script. I'd also point out that we don't expect too many people (if any) to attempt to run the script themselves: it is there primarily to document how the instance was generated. In other words, making this a raw URL makes it no easier for a sophisticated user to obtain a local copy of the script and if it makes it easier for an unsophisticated user to obtain such a copy without the code on which it depends, then that's probably a bad thing... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing:
https://github.com/dcppc/crosscut-metadata/blob/master/make-crosscut-instance-bdbag.sh
to
https://raw.githubusercontent.com/dcppc/crosscut-metadata/master/make-crosscut-instance-bdbag.sh
Allows a curl/wget of this needed script.