Conversation
AGENT: Codex
AGENT: Codex
AGENT: Codex
AGENT: Codex
SQLの種類を推測するメソッドに説明を記載し、公式ドキュメントへのリンクを追加しました。また、判別できない場合のログメッセージを追加し、ユーザーにissue提出を促す内容にしました。
AGENT: Codex
AGENT: Codex
AGENT: Codex
AGENT: Codex
AGENT: Codex
irof
commented
Feb 22, 2026
jig-core/src/main/java/org/dddjava/jig/domain/model/data/rdbaccess/MyBatisStatementId.java
Show resolved
Hide resolved
jig-core/src/main/java/org/dddjava/jig/domain/model/data/rdbaccess/SqlType.java
Outdated
Show resolved
Hide resolved
| return outputAdapters.stream() | ||
| // output adapterの実装しているoutput portのgatewayを | ||
| .flatMap(outputAdapter -> outputAdapter.implementsPortStream(jigTypes) | ||
| // interfaceのRepository(Spring Data JDBCなど)は実装クラスが存在しないため、自身をoutput portとして扱う |
Collaborator
Author
There was a problem hiding this comment.
元々のコメントが書きかけなのはおいといて。。。
この処理さらにアレになったなぁ
jig-core/src/main/java/org/dddjava/jig/domain/model/knowledge/datasource/DatasourceAngles.java
Outdated
Show resolved
Hide resolved
| return new SqlStatements(Stream.concat( | ||
| myBatisStatements.list().stream(), | ||
| springDataJdbcStatements.list().stream()) | ||
| .distinct() |
.../main/java/org/dddjava/jig/infrastructure/springdatajdbc/SpringDataJdbcStatementsReader.java
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| private String defaultQuery(SqlType sqlType, String tableName) { |
Collaborator
Author
There was a problem hiding this comment.
これが必要なのは元の作りの悪さな気がするな。。。
...st/java/org/dddjava/jig/infrastructure/springdatajdbc/SpringDataJdbcStatementReaderTest.java
Show resolved
Hide resolved
テーブル名解析失敗時のログメッセージを簡潔に改善し、「解析失敗」と明示しました。これにより、ログ内容がより分かりやすくなります。
AGENT: Codex
AGENT: Codex
AGENT: Codex
AGENT: Codex
rawTextとnormalizedQueryを分離し、SQLの正規化処理をQuery内に集約しました。これにより、SQL解析ロジックの一貫性が向上し、コードの可読性とメンテナンス性が改善されました。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.