Replace Fixed Randomness with Halo2 Fiat Shamir Transformation#39
Open
span14 wants to merge 17 commits intoddkang:mainfrom
Open
Replace Fixed Randomness with Halo2 Fiat Shamir Transformation#39span14 wants to merge 17 commits intoddkang:mainfrom
span14 wants to merge 17 commits intoddkang:mainfrom
Conversation
ddkang
reviewed
Sep 11, 2023
Cargo.toml
Outdated
| [dependencies] | ||
| bitvec = "1.0.1" | ||
| halo2 = { git="https://github.com/privacy-scaling-explorations/halo2", package="halo2", rev="17e9765c199670534c0299c96128d0464a188d0b" } | ||
| halo2_curves = { git = "https://github.com/privacy-scaling-explorations/halo2curves", tag = "0.3.3", package = "halo2curves" } |
Owner
There was a problem hiding this comment.
Use the same revision as the other ones
src/bin/verify_circuit.rs
Outdated
| panic!("Must specify kzg or ipa"); | ||
| } | ||
|
|
||
src/gadgets/bias_div_floor_relu6.rs
Outdated
| let mut x_pos = x - div_outp_min_val_i64; | ||
| if !relu_map.contains_key(&(x_pos)) { | ||
| println!("x: {}, x_pos: {}", x, x_pos); | ||
| // println!("x: {}, x_pos: {}", x, x_pos); |
src/gadgets/bias_div_round_relu6.rs
Outdated
| let mut x_pos = x - div_outp_min_val_i64; | ||
| if !relu_map.contains_key(&(x_pos)) { | ||
| println!("x: {}, x_pos: {}", x, x_pos); | ||
| // println!("x: {}, x_pos: {}", x, x_pos); |
Owner
|
I don't think this is secure. |
ddkang
reviewed
Sep 19, 2023
| .collect(); | ||
| let public_vals_u8_size = serialize(&public_vals_u8, "public_vals"); | ||
| println!("Public vals size: {} bytes", public_vals_u8_size); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses extra columns to hold the witnesses in the first phase to generate a commitment. This commitment can be used for randomness generation and the rest of the processes remain the same.
Places to Improve: