Skip to content

⚡ Bolt: Optimize JSON serialization in aselmdb.py with orjson#4

Open
alinelena wants to merge 1 commit intomainfrom
bolt-optimize-aselmdb-json-serialization-2340964486707200632
Open

⚡ Bolt: Optimize JSON serialization in aselmdb.py with orjson#4
alinelena wants to merge 1 commit intomainfrom
bolt-optimize-aselmdb-json-serialization-2340964486707200632

Conversation

@alinelena
Copy link
Copy Markdown
Contributor

💡 What:
Replaced ase.io.jsonio.encode and decode in aselmdb.py with orjson.dumps (using OPT_SERIALIZE_NUMPY) and orjson.loads. Added fallback to ASE's original methods for specific custom serialization formats (e.g. strings containing __ndarray__ or __complex__). Also cleaned up unused imports across a few files.

🎯 Why:
The standard JSON serialization/deserialization used by ASE when reading and writing to an LMDB database is a performance bottleneck. In pipelines handling thousands of structures, this adds significant overhead. orjson is much faster, particularly for numpy arrays which are native to ASE Atoms objects.

📊 Impact:
Expect a ~4-5x speedup for writing to LMDB and ~5-6x speedup for reading from LMDB per row operations in aselmdb.py.

🔬 Measurement:
Run python -m pytest tests/test_convert_to_lmdb.py to ensure LMDB serialization works identically. Profile cv_xyz_to_lmdb and cv_lmdb_to_xyz to observe execution time improvements.


PR created automatically by Jules for task 2340964486707200632 started by @alinelena

Replaced ASE's standard `jsonio.encode` and `decode` with `orjson` in `src/lavello_mlips/aselmdb.py` to significantly improve LMDB database write/read speeds. Added fallback logic to handle custom ASE objects (e.g. `__ndarray__`). Also removed unused imports flagged by ruff.

Co-authored-by: alinelena <3306823+alinelena@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant