⚡ Bolt: Replace ASE JSON decode with orjson for faster LMDB reads#5
⚡ Bolt: Replace ASE JSON decode with orjson for faster LMDB reads#5
Conversation
Replaced `ase.io.jsonio.decode` with `orjson.loads` in `decode_bytestream`, falling back to ASE decode only when necessary (for `__ndarray__` and `__complex__`). Avoided `.decode("utf-8")` string conversion before decoding because orjson can decode bytes. This speeds up LMDB reads by 4-5x.
Co-authored-by: alinelena <3306823+alinelena@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced
ase.io.jsonio.decodewithorjson.loadsindecode_bytestream, falling back to ASE decode only when necessary (for__ndarray__and__complex__). Avoided.decode("utf-8")string conversion before decoding.🎯 Why: Decoding JSON from LMDB is a significant bottleneck when reading data.
orjsonis much faster than the standard libraryjsonmodule used by ASE. Since the repo already includesorjsoninpyproject.toml, replacing it gives a significant speedup for free.📊 Impact: Improves LMDB read performance by bypassing standard json decoding for simple properties. A simple read row benchmark showed decoding becomes ~4.6x faster!
🔬 Measurement: Verified by running existing test suite
test_aselmdb.pyto ensure reads matching standard formatting and properties with complex ASE types fall back properly without breaking.PR created automatically by Jules for task 6280134183146605104 started by @alinelena