Open
Conversation
joehart2001
reviewed
Mar 20, 2026
| Computational cost | ||
| ------------------ | ||
|
|
||
| Medium: benchmark involves only single-point calculations, but for 36,718 slab-bulk pairs. |
Collaborator
There was a problem hiding this comment.
it would be good to give a rough indication of time e.g. hours on gpu and minutes on gpu?
Author
There was a problem hiding this comment.
Yes sorry, on GPU it's roughly 5–20 mins, and a few hours on CPUs.
joehart2001
reviewed
Mar 22, 2026
joehart2001
reviewed
Mar 22, 2026
joehart2001
reviewed
Mar 22, 2026
joehart2001
reviewed
Mar 22, 2026
Collaborator
|
Hey @vue1999, thanks for the PR and its looking super good. A few things:
Let me know if you've got any ideas or are unsure about any of my suggestions, thanks! |
joehart2001
reviewed
Mar 22, 2026
joehart2001
reviewed
Mar 22, 2026
ml_peg/analysis/surfaces/cleavage_energy/analyse_cleavage_energy.py
Outdated
Show resolved
Hide resolved
joehart2001
reviewed
Mar 22, 2026
ml_peg/analysis/surfaces/cleavage_energy/analyse_cleavage_energy.py
Outdated
Show resolved
Hide resolved
ml_peg/analysis/surfaces/cleavage_energy/analyse_cleavage_energy.py
Outdated
Show resolved
Hide resolved
ml_peg/analysis/surfaces/cleavage_energy/analyse_cleavage_energy.py
Outdated
Show resolved
Hide resolved
ml_peg/analysis/surfaces/cleavage_energy/analyse_cleavage_energy.py
Outdated
Show resolved
Hide resolved
ml_peg/analysis/surfaces/cleavage_energy/analyse_cleavage_energy.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
…gy.py Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
…gy.py Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
…gy.py Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
…gy.py Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
…gy.py Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
…gy.py Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
…gy.py Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
…gy.py Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
…gy.py Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
…gy.py Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
…gy.py Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
…gy.py Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
…gy.py Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
…gy.py Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
…gy.py Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
…gy.py Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
…gy.py Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
…gy.py Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
Author
|
Thanks for the review @joehart2001! Happy to accept all suggestions and fine to keep just MAE for now. |
joehart2001
reviewed
Mar 25, 2026
Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist for PR author
PR author must check the checkboxes below when creating the PR.
Summary
Adding a benchmark to evaluate the accuracy of predicting cleavage energies of crystalline surfaces.
Linked issue
Resolves #403
Progress
Testing
MACE omat, ORB v3
New decorators/callbacks
no