Skip to content

Split vacancies benchmark#437

Draft
ThomasWarford wants to merge 21 commits intoddmms:mainfrom
ThomasWarford:split_vacancies_benchmark
Draft

Split vacancies benchmark#437
ThomasWarford wants to merge 21 commits intoddmms:mainfrom
ThomasWarford:split_vacancies_benchmark

Conversation

@ThomasWarford
Copy link
Copy Markdown
Contributor

@ThomasWarford ThomasWarford commented Mar 23, 2026

Pre-review checklist for PR author

PR author must check the checkboxes below when creating the PR.

Summary

Based on this paper: Identifying split vacancy defects with machine-learned foundation models and electrostatics

The metrics:

  • Formation energy of split-vacancy defects from fully ionised defects
  • Spearman's coefficient for ranking the energies of initial defect structures.
  • RMSD of MLIP relaxed structures vs DFT relaxed structures. (Note the initial structure for the MLIP relaxation is currently the DFT relaxed structure.)

Linked issue

#335

Progress

  • Calculations
  • Analysis
  • Application
  • Documentation

Testing

New decorators/callbacks

@ThomasWarford ThomasWarford force-pushed the split_vacancies_benchmark branch from 5a053c7 to a65e1e8 Compare March 23, 2026 22:34
@ThomasWarford
Copy link
Copy Markdown
Contributor Author

@joehart2001 @ElliottKasoar do you think this belongs in a "defects" section rather than bulk crystals?

@ThomasWarford
Copy link
Copy Markdown
Contributor Author

Here's how the table looks at the moment

image

@joehart2001
Copy link
Copy Markdown
Collaborator

@joehart2001 @ElliottKasoar do you think this belongs in a "defects" section rather than bulk crystals?

Yes i totally agree. We have some other PRs that could maybe fit in a defects category, like #337 creates an interstitial category, so we could merge you two. but its something we can move around easily anyway

@joehart2001
Copy link
Copy Markdown
Collaborator

Here's how the table looks at the moment

image

Looking good, potentially don't need rmsd as well as MAE? hopefully we'll have an option soon to switch between different types of errors automatically.

@ThomasWarford
Copy link
Copy Markdown
Contributor Author

The RMSD metric is still subject to change, since it is sensitive to the accuracy of the bulk structure as well as the defect structure (which is what we are interested in).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants