Minor issues prior to save load

[deanblackborough]

Summary by CodeRabbit

Bug Fixes

• V-Sync setting now correctly respects user configuration instead of always being enabled
• Diagonal camera movement is now consistent with single-axis movement
• Scene state properly resets when entering or exiting the sandbox environment
• Frame time display calculation improved with guards against invalid frame rates
• Game object selection now properly handles invalid selections

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request refines several core systems across the engine. It adds conditional rendering flags for V-sync in window creation, explicitly handles invalid game object IDs in the selection system, resets internal scene state deterministically on entry and exit, normalises camera movement input to prevent diagonal acceleration, removes an unused parameter from the block spawner function signature, and guards frame-time calculations in the stats display. These changes touch renderer configuration, selection semantics, scene lifecycle management, input handling, and utility functions without altering exported API signatures.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

• Upgrade game objects #8: Introduces kInvalidGameObjectId and GameObjectId-based selection; this PR builds on that by adding explicit handling of invalid IDs in GameObjectManager::select()
• Save and load and bugs #20: Modifies src/prune/core/window.cpp renderer creation logic; this PR extends that with conditional V-sync flag computation at runtime
• Highlight selected and update structure #9: Modifies SandboxScene implementation; this PR further enhances scene lifecycle by resetting internal state on entry and exit

Suggested labels

enhancement

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title "Minor issues prior to save load" is vague and doesn't clearly indicate the specific changes made across six files (renderer flags, game object selection, scene state resets, camera movement normalisation, function signature removal, and frame time calculations).	Consider a more descriptive title that captures the primary focus, such as "Fix scene state management and camera movement" or "Refactor renderer configuration and scene initialisation".

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch minor-issues

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d5278e96-8081-4012-962b-bb3f590e8814

📥 Commits

Reviewing files that changed from the base of the PR and between b26e470 and 5d568c6.

📒 Files selected for processing (7)

• src/prune/core/window.cpp
• src/prune/scene/game_object_manager.cpp
• src/prune/scene/sandbox_scene.cpp
• src/prune/scene/sandbox_scene_editor.cpp
• src/prune/tooling/outliner.cpp
• src/prune/tooling/outliner.hpp
• src/prune/tooling/stats.cpp

💤 Files with no reviewable changes (2)

• src/prune/tooling/outliner.hpp
• src/prune/tooling/outliner.cpp