This repository was archived by the owner on Sep 18, 2024. It is now read-only.
Add pathfinder 2e system-specific rules for critical and a way to not play sound on blind rolls#187
Open
tgermain wants to merge 7 commits intodeath-save:masterfrom
Open
Add pathfinder 2e system-specific rules for critical and a way to not play sound on blind rolls#187tgermain wants to merge 7 commits intodeath-save:masterfrom
tgermain wants to merge 7 commits intodeath-save:masterfrom
Conversation
added 7 commits
April 1, 2023 22:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took the liberty to do a bit of cleanup and reformat first. I couldn't find if there a specific code format style for maestro so I used the default one coming with visual studio code (no trailing space, indent using 4 spaces).
First new feature add a settings to be able to play sound on blind rolls or not.
By default, I kept the existing behavior so it should play sound on every rolls.
Second new feature add a way to detect critical success and failure as per pathfinder 2e rules.
If the game world is not using pf2e system, enabling that feature won't do anything.
By default, the setting is disabled to keep the same behavior as before.
It should fix #156
I thought about moving "the play sound on critical" features and related functions out of
misc.jsto acritical.js, what do you think?