Conversation
layouts/default.vue
Outdated
|
|
||
| <script setup> | ||
| const headerData = { | ||
| logo: '/icons/logo.svg', |
There was a problem hiding this comment.
logo, select, close можно вынести из данных в Header
| </template> | ||
|
|
||
| <script setup> | ||
| import { ref } from 'vue'; |
There was a problem hiding this comment.
Можно отказаться от import
| const props = defineProps({ | ||
| logo: String, | ||
| select: String, | ||
| close: String, |
There was a problem hiding this comment.
logo, select, close можно убрать из props
| <img :src="logo" alt="Logo" /> | ||
| </div> | ||
|
|
||
| <nav class="header__nav-desktop"> |
There was a problem hiding this comment.
Завернуть nav и button в обертку, button вынести из nav
Обертка будет меню на мобилке (через transfrom: translateX)
|
|
||
| @include media-breakpoint-up(md) { | ||
| padding-top: rem(62); | ||
| height: rem(68); |
There was a problem hiding this comment.
Лучше отказаться от фиксированный высоты и добиваться нужной высоты за счет padding
components/atoms/Button/Button.vue
Outdated
| }; | ||
| }); | ||
| onMounted(() => { | ||
| console.log(props.text); |
|
|
||
| border-radius: rem(48); | ||
| height: rem(40); | ||
| background-color: $color-white; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
assets/scss/vars/_typography.scss
Outdated
| 'Helvetica Neue', Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', | ||
| 'Segoe UI Symbol' !default; | ||
|
|
||
| $font-family-monospace: SFMono-Regular, Menlo, Monaco, Consolas, |
There was a problem hiding this comment.
Можно убрать, не используется
assets/scss/vars/_grid.scss
Outdated
| $grid-breakpoints: ( | ||
| sm: 0, | ||
| md: 430px, | ||
| lg: 1440px, |
assets/scss/main.scss
Outdated
| @import 'utils/index'; | ||
|
|
||
| :root { | ||
| --color-neon-green: #b9ff66; |
assets/scss/base/_scale-html.scss
Outdated
| font-size: 16px; | ||
|
|
||
| @media (max-width: 430px) { | ||
| font-size: 14px; |
There was a problem hiding this comment.
Можно попробовать написать цикл с проверками
…liderTestimonials wip (рамка для слайда, пр верстка)
assets/scss/base/_scale-html.scss
Outdated
| // html { | ||
| // font-size: 16px; | ||
|
|
||
| // @media (max-width: 430px) { |
There was a problem hiding this comment.
Остался закомментированный код
assets/scss/libs/_swiper.scss
Outdated
| .swiper-pagination-bullet { | ||
| // margin: 0 !important; | ||
| // background-color: $color-neon-green !important; | ||
| // opacity: 1 !important; |
There was a problem hiding this comment.
Остался закомментированный код
assets/scss/vars/_grid.scss
Outdated
| @@ -0,0 +1,13 @@ | |||
| // $grid-breakpoints: ( | |||
There was a problem hiding this comment.
Остался закомментированный код
components/atoms/Action/Action.scss
Outdated
| @include text-header; | ||
| @include media-breakpoint-up(lg) { | ||
| display: block; | ||
| margin-top: rem(4); |
There was a problem hiding this comment.
2 момента:
- Почему 4px, если на макетах по 6.5px?
- Можно отказаться от margin-top и задать для &__wrapper align-items: center. Судя по макетам, текст выравнивается по центру.
components/atoms/Action/Action.scss
Outdated
| } | ||
| &--icon-right { | ||
| #{$b}__wrapper { | ||
| display: flex; |
There was a problem hiding this comment.
Дублирование, можно отказаться от части свойств
components/atoms/Input/Input.scss
Outdated
| top: rem(-32); | ||
| left: 0; | ||
| color: $color-black; | ||
| padding: 0 rem(4); |
| [`input--${props.type}`]: props.type, | ||
| 'input--error': props.required && !props.placeholder, | ||
| 'input--focused': focused.value, | ||
| 'input--filled': Boolean(props.placeholder), |
There was a problem hiding this comment.
Не совсем понял для чего это нужно
components/atoms/Intro/Intro.vue
Outdated
| <div class="intro"> | ||
| <h2 v-if="title" class="intro__title" v-html="title"></h2> | ||
| <div v-if="titleUpper || titleLower" class="intro__header"> | ||
| <h2 class="intro__title-upper"> |
components/atoms/Action/Action.vue
Outdated
| @@ -0,0 +1,51 @@ | |||
| <template> | |||
| <div class="action" :class="classes"> | |||
There was a problem hiding this comment.
Убрать div, вместо него заменить на это:
<AtomsLink v-if="href" :href="href" :class="classes">
components/atoms/Input/Input.vue
Outdated
| id: String, | ||
| name: String, | ||
| type: { type: String, default: 'text' }, | ||
| placeholder: { type: String, default: '' }, |
2 participants
No description provided.