Hello, small fix to HTTP calls appending 'undefined' to URL#23
Open
nukleas wants to merge 1 commit intodebrouwere:masterfrom
Open
Hello, small fix to HTTP calls appending 'undefined' to URL#23nukleas wants to merge 1 commit intodebrouwere:masterfrom
nukleas wants to merge 1 commit intodebrouwere:masterfrom
Conversation
… it (url.search was undefined, would concatenate undefined to end of url)
pixelistik
added a commit
to pixelistik/Extendables
that referenced
this pull request
Mar 5, 2014
If a URL has no query string, the HTTP package added the string 'undefined' to the end of the URL. This fix reduces the failing assertions in the existing tests for the HTTP package from 8 to 1 (using InDesign CS6 as the environment). This fix is similar to pull request debrouwere#23.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I was trying to make calls to dx.doi.org 's site using Extendables, but I noticed an appending of "undefined" to the end of my called URL, which would then cause the site to give me a 'DOI not found' error. I seemed to find the place where this was happening, and I made it so that if url.search was undefined, it would default to a blank string, which wouldn't affect the HTTP call.
Hopefully this change is useful,
Nukleas
... (url.search was undefined, would concatenate undefined to end of url)