Skip to content

fix(terminal): ignore errors when killing PTY on Windows #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
debuglebowski merged 1 commit into from
Apr 6, 2026
Merged

fix(terminal): ignore errors when killing PTY on Windows #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/domains/terminal/src/main/pty-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1344,7 +1344,12 @@ export function killPty(sessionId: string): boolean {
sessions.delete(sessionId)
notifySessionChange()
// Use SIGKILL (9) to forcefully terminate - SIGTERM may not kill child processes
session.pty.kill('SIGKILL')
// Wrap in try/catch: on Windows, killing an already-dead process throws
try {
session.pty.kill('SIGKILL')
} catch {
// Process already exited — not an error
}
Comment on lines +1350 to +1352
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Silent catch reduces observability

The analogous resizePty try/catch (around line 1296) records a pty.resize_failed diagnostic event before swallowing the error, which makes it possible to correlate Windows kill failures in diagnostic logs. The new catch here is completely silent.

Consider recording a warn-level diagnostic event so the condition is visible in telemetry without causing the call to fail:

Suggested change
} catch {
// Process already exited — not an error
}
} catch (error) {
// Process already exited — not an error on Windows
recordDiagnosticEvent({
level: 'warn',
source: 'pty',
event: 'pty.kill_failed',
sessionId,
taskId: session.taskId,
message: (error as Error).message
})
}
Prompt To Fix With AI 
This is a comment left during a code review.
Path: packages/domains/terminal/src/main/pty-manager.ts
Line: 1350-1352

Comment:
**Silent catch reduces observability**

The analogous `resizePty` try/catch (around line 1296) records a `pty.resize_failed` diagnostic event before swallowing the error, which makes it possible to correlate Windows kill failures in diagnostic logs. The new catch here is completely silent.

Consider recording a `warn`-level diagnostic event so the condition is visible in telemetry without causing the call to fail:

```suggestion
  } catch (error) {
    // Process already exited — not an error on Windows
    recordDiagnosticEvent({
      level: 'warn',
      source: 'pty',
      event: 'pty.kill_failed',
      sessionId,
      taskId: session.taskId,
      message: (error as Error).message
    })
  }
```

How can I resolve this? If you propose a fix, please make it concise.

return true
}

Expand Down
Loading