fix(editor): fix compact line spacing not working with Milkdown#63
Open
sfarestam wants to merge 1 commit intodebuglebowski:mainfrom
Open
fix(editor): fix compact line spacing not working with Milkdown#63sfarestam wants to merge 1 commit intodebuglebowski:mainfrom
sfarestam wants to merge 1 commit intodebuglebowski:mainfrom
Conversation
The compact spacing CSS selectors targeted .ProseMirror.prose but after the TipTap-to-Milkdown migration, .ProseMirror no longer has the .prose class (it's on a parent div). Remove .prose from the selectors so they match the Milkdown DOM structure. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.ProseMirror.prosebut Milkdown renders.ProseMirroras a separate element without theproseclass (.proseis on a parent div).prosefrom all compact spacing selectors so they match.prose-tight .ProseMirrorTest plan
🤖 Generated with Claude Code
Greptile Summary
Fixes compact line spacing not applying in the Milkdown editor by removing the
.proseclass co-requirement from all fiveprose-tightCSS selector groups. After the TipTap→Milkdown migration,.ProseMirrorno longer carries the.proseclass, so the old.prose-tight .ProseMirror.proseselectors never matched Milkdown's DOM structure.Confidence Score: 5/5
Safe to merge — minimal, targeted CSS fix with no logic changes
Single-file CSS change that broadens five selector groups from requiring .ProseMirror.prose to .ProseMirror. Fix is correct, well-scoped, and no P0/P1 issues found. All other .ProseMirror.prose selectors (editor-themed theming) are correctly left untouched.
No files require special attention
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[User sets Line Spacing: Compact] --> B[prose-tight class added to editor container] B --> C{Which editor?} C -->|TipTap| D[".ProseMirror.prose element"] C -->|Milkdown| E[".ProseMirror element\n.prose on parent div"] D --> F["OLD: .prose-tight .ProseMirror.prose ✓\nNEW: .prose-tight .ProseMirror ✓"] E --> G["OLD: .prose-tight .ProseMirror.prose ✗\nNEW: .prose-tight .ProseMirror ✓"] F --> H[Compact spacing applied] G --> HReviews (1): Last reviewed commit: "fix(editor): fix compact line spacing no..." | Re-trigger Greptile