fix(ci): resolve npm/TypeScript conflict for UI build#252
Open
fix(ci): resolve npm/TypeScript conflict for UI build#252
Conversation
- Bump TypeScript to ^5.0.0 in web/ui (required by react-i18next 15 types) - Use npm install --legacy-peer-deps in Makefile and werf.yaml so install succeeds despite react-scripts@5 peerOptional typescript ^3||^4 Fixes CI build_dev / build-and-push failing with TS2554 and ERESOLVE. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI job
build_dev / build-and-pushwas failing after dependency updates (e.g. job 65873337697).Root cause:
useTranslation(namespace)typing; on TS 4.9 the build failed withTS2554: Expected 0 arguments, but got 1in UI components.peerOptionalDependencies: typescript ^3 || ^4, sonpm installwith TypeScript 5 in a clean environment failed with ERESOLVE.Solution
web/uifrom^4.9.5to^5.0.0.npm install --legacy-peer-depsin Makefile (ui-install,ui-bump-version) and in werf.yaml so install succeeds despite the peer conflict.Verification
make buildpasses in devcontainer (ARM).npm install --legacy-peer-deps && npm run buildinweb/ui.Made with Cursor