Skip to content

chore(api): block migration during snapshotting and snapshotting during migration #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eofff wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(api): block migration during snapshotting and snapshotting during migration #2031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78d457f
fix
Feb 27, 2026
7d334d9
frozen -> snapshotting
Mar 4, 2026
bc0a8f7
message refactoring
Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions images/virtualization-artifact/pkg/controller/vm/internal/migrating.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,15 @@ func (h *MigratingHandler) getVMOPCandidate(ctx context.Context, s state.Virtual
func (h *MigratingHandler) syncMigratable(ctx context.Context, s state.VirtualMachineState, vm *v1alpha2.VirtualMachine, kvvm *virtv1.VirtualMachine, kvvmi *virtv1.VirtualMachineInstance) error {
cb := conditions.NewConditionBuilder(vmcondition.TypeMigratable).Generation(vm.GetGeneration())

snapshotting, _ := conditions.GetCondition(vmcondition.TypeSnapshotting, vm.Status.Conditions)
if snapshotting.Status == metav1.ConditionTrue {
cb.Status(metav1.ConditionFalse).
Reason(vmcondition.ReasonNonMigratable).
Message("Cannot migrate the machine while a snapshot is in progress.")
conditions.SetCondition(cb, &vm.Status.Conditions)
return nil
}

if kvvm != nil {
liveMigratable := service.GetKVVMCondition(string(virtv1.VirtualMachineInstanceIsMigratable), kvvm.Status.Conditions)
switch {
Expand Down
2 changes: 1 addition & 1 deletion images/virtualization-artifact/pkg/controller/vmop/migration/internal/handler/lifecycle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ func (h LifecycleHandler) canExecute(vmop *v1alpha2.VirtualMachineOperation, vm
Generation(vmop.GetGeneration()).
Reason(vmopcondition.ReasonOperationFailed).
Status(metav1.ConditionFalse).
Message("VirtualMachine is not migratable, cannot be processed."),
Message(fmt.Sprintf("VirtualMachine is not migratable, cannot be processed: %s", migratable.Message)),
&vmop.Status.Conditions)
return false
}
Expand Down
9 changes: 9 additions & 0 deletions images/virtualization-artifact/pkg/controller/vmsnapshot/internal/virtual_machine_ready.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,15 @@ func (h VirtualMachineReadyHandler) Handle(ctx context.Context, vmSnapshot *v1al
return reconcile.Result{}, nil
}

_, migratingConditionExists := conditions.GetCondition(vmcondition.TypeMigrating, vm.Status.Conditions)
if migratingConditionExists {
cb.
Status(metav1.ConditionFalse).
Reason(vmscondition.VirtualMachineNotReadyForSnapshotting).
Message("Snapshot cannot be taken: the virtual machine is currently migrating.")
return reconcile.Result{}, nil
}

switch vm.Status.Phase {
case v1alpha2.MachineRunning, v1alpha2.MachineStopped:
// If the snapshotting condition is not found, it means that the vm is ready for snapshotting.
Expand Down
Loading