feat(Page): add cache control options and headers for CDN caching#1465
feat(Page): add cache control options and headers for CDN caching#1465
Conversation
Tagging OptionsShould a new tag be published when this PR is merged?
|
WalkthroughVersion control now ignores cursor indexing and specstory directories. Page component adds CDN/page-level caching support through new props and header management utilities, with backward compatibility for legacy cache configurations. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Areas requiring attention:
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.gitignore(1 hunks)website/pages/Page.tsx(3 hunks)
🧰 Additional context used
🪛 GitHub Actions: ci
website/pages/Page.tsx
[error] 20-20: TS2305: Module 'https://jsr.io/@deco/deco/1.128.2/utils/mod.ts' has no exported member 'DECO_PAGE_CACHE_ALLOW_HEADER'.
[error] 21-21: TS2305: Module 'https://jsr.io/@deco/deco/1.128.2/utils/mod.ts' has no exported member 'DECO_PAGE_CACHE_CONTROL_HEADER'.
[error] 22-22: TS2305: Module 'https://jsr.io/@deco/deco/1.128.2/utils/mod.ts' has no exported member 'normalizeCacheControlHeader'.
| import { | ||
| DECO_PAGE_CACHE_ALLOW_HEADER, | ||
| DECO_PAGE_CACHE_CONTROL_HEADER, | ||
| normalizeCacheControlHeader, | ||
| } from "@deco/deco/utils"; |
There was a problem hiding this comment.
Fix missing exports before merge
The CI run for November 12, 2025 is failing with TS2305 because @deco/deco@1.128.2/utils does not export DECO_PAGE_CACHE_ALLOW_HEADER, DECO_PAGE_CACHE_CONTROL_HEADER, or normalizeCacheControlHeader. Please point these imports at a module that actually exports them (or update the dependency to a version that does) so the project compiles.
🧰 Tools
🪛 GitHub Actions: ci
[error] 20-20: TS2305: Module 'https://jsr.io/@deco/deco/1.128.2/utils/mod.ts' has no exported member 'DECO_PAGE_CACHE_ALLOW_HEADER'.
[error] 21-21: TS2305: Module 'https://jsr.io/@deco/deco/1.128.2/utils/mod.ts' has no exported member 'DECO_PAGE_CACHE_CONTROL_HEADER'.
[error] 22-22: TS2305: Module 'https://jsr.io/@deco/deco/1.128.2/utils/mod.ts' has no exported member 'normalizeCacheControlHeader'.
🤖 Prompt for AI Agents
In website/pages/Page.tsx around lines 19 to 23, the current import targets
DECO_PAGE_CACHE_ALLOW_HEADER, DECO_PAGE_CACHE_CONTROL_HEADER, and
normalizeCacheControlHeader from "@deco/deco/utils", but that module version
(1.128.2) does not export those symbols; either update the dependency to a
release that exports them or change the import to the module that actually
exports them (e.g., import from the correct path in @deco/deco such as
"@deco/deco/cache" or the module where those names live). Modify the import
statement to reference the correct module, then run the lockfile install
(npm/yarn/pnpm install) and re-run TypeScript to ensure TS2305 is resolved.
Summary by CodeRabbit
Release Notes