Price Range filter on Vtex legacy PLP #191
Open
jovenan wants to merge 2 commits intodeco-sites:mainfrom
Open
Conversation
mcandeia
requested changes
Aug 11, 2023
Contributor
mcandeia
left a comment
There was a problem hiding this comment.
Looks good, but I would try to remove all uses of regex. Except for certain types of encryption, regex is the second slowest CPU-intensive operation one can perform. I only use regex in cases where it's absolutely necessary, for instance, if you can transform it into startswith/endswith/includes, that would be ideal. Keep in mind that this runs for each request and is CPU-bound. Since Deno is single-threaded, the main thread gets occupied processing regex. And even though it might seem insignificant, when you have hundreds and thousands of simultaneous requests, it ends up making a difference of milliseconds per request.
Author
|
@mcandeia Thanks for review. I made these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature description
Allows Price Range filter on Vtex legacy ProductListingPage:

By default Vtex sends a JSON like this to loader:

But we can't use this url format in deco, because it returns an error, as it can't handle filters of this type.
In this PR we use the
fq=P:[{a} TO {b}]to filter by the range prices registered in the vtex.