-
Notifications
You must be signed in to change notification settings - Fork 1
Feat threads #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aka-sacci-ccr
wants to merge
2
commits into
main
Choose a base branch
from
feat-threads
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat threads #117
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /** | ||
| * PostgreSQL Database Module | ||
| * | ||
| * Generic SQL runner using the DATABASE binding. | ||
| */ | ||
|
|
||
| import type { Env } from "../main.ts"; | ||
|
|
||
| /** | ||
| * Run a SQL query using the DATABASE binding | ||
| * @param env - The environment containing the DATABASE binding | ||
| * @param sql - SQL query with ? placeholders | ||
| * @param params - Parameters to substitute for ? placeholders | ||
| * @returns The query results as an array of rows | ||
| */ | ||
| export async function runSQL<T = unknown>( | ||
| env: Env, | ||
| sql: string, | ||
| params: unknown[] = [], | ||
| ): Promise<T[]> { | ||
| // Defensive: some DATABASE bindings may interpolate params into SQL literals. | ||
| // Ensure single quotes inside string params don't break the query. | ||
| const sanitizedParams = params.map((p) => { | ||
| if (typeof p === "string") return p.replaceAll("'", "''"); | ||
| return p; | ||
| }); | ||
| const response = | ||
| await env.MESH_REQUEST_CONTEXT?.state?.DATABASE.DATABASES_RUN_SQL({ | ||
| sql, | ||
| params: sanitizedParams, | ||
| }); | ||
| return (response.result[0]?.results ?? []) as T[]; | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1: Missing optional chaining on
DATABASE. Ifstateexists butDATABASEis undefined, accessing.DATABASES_RUN_SQL()will throw.Prompt for AI agents