fix(gateway): reject GET requests to prevent SSE reconnection loop#2305
Open
fix(gateway): reject GET requests to prevent SSE reconnection loop#2305
Conversation
Virtual MCPs are stateless aggregators that create a new transport per request. For GET requests (SSE streaming), handleRequest returns after setting up the stream, but our finally block immediately closes the transport, terminating the connection. Clients then reconnect, creating an infinite loop. By rejecting GET requests with a 405 and JSON-RPC error, clients fall back to POST-only mode which works correctly with our stateless model.
Contributor
🧪 BenchmarkShould we run the Virtual MCP strategy benchmark for this PR? React with 👍 to run the benchmark.
Benchmark will run on the next push after you react. |
Contributor
Release OptionsShould a new version be published when this PR is merged? React with an emoji to vote on the release type:
Current version: Deployment
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Virtual MCPs are stateless aggregators that create a new transport per request. For GET requests (SSE streaming), handleRequest returns after setting up the stream, but our finally block immediately closes the transport, terminating the connection. Clients then reconnect, creating an infinite loop.
By rejecting GET requests with a 405 and JSON-RPC error, clients fall back to POST-only mode which works correctly with our stateless model.
Summary by cubic
Reject GET requests on the virtual MCP gateway to stop the SSE reconnection loop with stateless transports. Returns 405 with a JSON-RPC error so clients fall back to POST-only mode.
Written for commit a55280b. Summary will update on new commits.