-
Notifications
You must be signed in to change notification settings - Fork 13
Patch Clang for Switch #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Very cool, thanks for the PR. Is 4.0.1 the only version with patches? |
|
It's the only version that we've discovered changes for. Existing projects using other Clang versions make minimal use of the STL so there may be patches required later on. |
|
Does it make sense to download the zip of the repo rather than git clone-ing? |
|
That does make more sense, yep. |
|
I updated the templates again so the workflow should (hopefully) pass. Sorry for all the commits, please squash them when merging! |
|
No worries, seems the actual patching is failing now though? |
|
It should work if you rerun the workflow now, I had generated these patches in a different directory earlier so |
|
Hopefully that should be the last fix. I tested it locally this time and it all works. |
The Switch uses Clang for compiling, but makes some modifications to the STL that we need to replicate to match some code.
Instead of shipping a custom modified zip of clang (from a slower mirror than LLVM), and having to update the zip when we make any new patches, this .diff system should let us add new patches without having to update the compilers repository.
These changes are required to compile/match some scratches on decomp.me.