-
Notifications
You must be signed in to change notification settings - Fork 149
ui: display your orders rate in header #2281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note, Is it something we want to fix (assuming it's possible to do without using external decimal-arithmetic libs) ? Reading through this discussion I've got a feeling that we don't care about this when displaying spot price (or similar). For order rate however user might be somewhat uneasy to see such rounding imo, but then ... we might run out of space to display rate without rounding. |
|
I draw a distinction between numerical "display" values and "data" values. Display values, such as the market statistics shown at the top of the markets view, can employ rounding or truncation and should use significant figures to make values "pretty". Data values, such as order data, should not employ rounding, and should use e.g. |
|
To resolve the issue mentioned in #2281 (comment) I'll need to apply similar fix implemented in #2278 (comment), for rate included in "header" in this PR. |
|
Can we just get this merged with the current reasonable solution (perhaps just forcing at least one decimal)? #2278 (comment) may contain the resolution, but is a can of worms and will preclude this small change from landing in 0.6.1 |
|
1.000001 is a rate that isn't likely to be practical (too much precision), so I'm inclined to just merge this as-is if there's not a quick resolution tomorrow. |
I'd rather not try to come up with yet another way to handle this specific case (and I don't see anything simple we can do here), so I'd wait until #2278 (comment) is ready, but merging as is is also fine, I believe, because we show this trimmed rate in "details" anyway, so showing in header as well doesn't really break anything. |
|
Right it's no deviation from existing convention. I'm asking for @buck54321 call though regarding asap merge resolution. |

Resolves #2254.
Rate fits reasonably well with the longest
canceled/settlingstatus and max rate step we currently have = 6