-
Notifications
You must be signed in to change notification settings - Fork 14
modify import & update README.md #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
update README.md modified README.md updated README.md update README.md file and import statements updated import statements
| .idea/ | ||
| .vscode/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For folders specific to your own environment, please use .git/info/exclude instead.
| To run tinydecred on your machine you will need to set up the following. | ||
|
|
||
| - pip install websocket_client | ||
| - pip install blake256 | ||
| - pip install base58 | ||
| - pip install PyNaCl | ||
| - pip install appdirs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't install this way. Regular users should just pip install decred.
For tinywallet, you can poetry install and then poetry run tinywallet, but you'll need the fix from #198.
| Set up and run dcrd. Ensure your rpcusername and rpcpassword is set in your dcrd config file. | ||
| Installation guide can be found [`here`](https://docs.decred.org/wallets/cli/dcrd-setup/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dcrd is completely optional, and it's integration is very shallow right now. I wouldn't say much about dcrd yet.
| from decred import DecredError | ||
| from decred.util import encode | ||
| from decred.util.encode import ByteArray, unblobCheck | ||
| from decred.decred import DecredError | ||
| from decred.decred.util import encode | ||
| from decred.decred.util.encode import ByteArray, unblobCheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't do this. Typically this would indicate that you are importing the package in a way that it wasn't intended. How are you using the package that requires this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I run tinywallet, without this change I was getting an importerror(unknown location), so I figured since it is absolute import, this would help. The only other fix I could figure out was the insertion of my projectpath using sys.path.insert().
This was what I used to make tinywallet run on my machine, I would be glad if you can proffer a better way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you using the CLI command poetry run tinywallet to run tinywallet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to pip install poetry and poetry install in the tinywallet directory first.
Sorry this stuff isn't better documented already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have implemented your suggestions, and I still got the error I dropped on tinydecred room..
what version of python are you using?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you referring to the IDE error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's actually not IDE related.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neither buck nor I are seeing this, and we use different flavors of linux I believe. I'm not great with poetry, but It looks like the virtual environment it uses isn't being set up properly on your end.
|
|
||
| ## Requirements | ||
|
|
||
| To run tinydecred on your machine you will need to set up the following. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't "run tinydecred". You can run tinywallet, or use the decred package.
|
Issue was resolved by fix from #198. |
The README.md is updated to properly guide the installation and running of tinydecred.