-
Notifications
You must be signed in to change notification settings - Fork 105
riscv: dts: ultrarisc: Add serial aliases for dp1000 boards #1421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: linux-6.6.y
Are you sure you want to change the base?
Conversation
This reverts commit ded9449.
community inclusion category: feature bugzilla: RVCK-Project/rvck#71 -------------------------------- Remove 'bootargs' and only use 'stdout-path'. Signed-off-by: Jia Wang <wangjia@ultrarisc.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds standard serial aliases (serial0-serial3) for existing UART nodes (uart0-uart3) in all dp1000 Ultrarisc board DTS files to improve uniform serial port naming and compatibility. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @WangJia-UR. Thanks for your PR. I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Ensure the new serial0–serial3 aliases are added under the existing /aliases node in each DTS and keep the alias list sorted consistently with the surrounding properties to match existing tree style.
- Double-check that the serialN -> uartN mapping matches whatever port is currently used for stdout-path/console on these boards, so the new aliases don’t unintentionally change which port users expect to be serial0.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Ensure the new serial0–serial3 aliases are added under the existing /aliases node in each DTS and keep the alias list sorted consistently with the surrounding properties to match existing tree style.
- Double-check that the serialN -> uartN mapping matches whatever port is currently used for stdout-path/console on these boards, so the new aliases don’t unintentionally change which port users expect to be serial0.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Add serial aliases (serial0-serial3) for UART devices (uart0-uart3)
in dp1000-evb-v1, dp1000-m0-v1, and dp1000-titan-v1 board DTS files.
Summary by Sourcery
Enhancements: