chore(dependencies): Downgrade matplotlib-inline for Python 3.10 #26
Conversation
📝 WalkthroughWalkthrough
Sequence Diagram(s)mermaid Repo->>CI: push PR triggers workflow Possibly related PRs
Suggested reviewers
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
🔇 Additional comments (3)
Comment |
|
📦 Python package built successfully!
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml(1 hunks)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
=======================================
Coverage 75.39% 75.39%
=======================================
Files 99 99
Lines 5625 5625
Branches 784 784
=======================================
Hits 4241 4241
Misses 1384 1384 ☔ View full report in Codecov by Sentry. |
|
🚀 Review App Deployment Started
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: Test - Python 3.13
- GitHub Check: Test - Python 3.12
- GitHub Check: Test - Python 3.10
- GitHub Check: Test - Python 3.11
- GitHub Check: Typecheck - 3.13
- GitHub Check: Typecheck - 3.10
- GitHub Check: Build and push artifacts for Python 3.11
- GitHub Check: Build and push artifacts for Python 3.12
- GitHub Check: Build and push artifacts for Python 3.13
- GitHub Check: Build and push artifacts for Python 3.10
- GitHub Check: Build and push artifacts for Python 3.9
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.github/workflows/ci.yml(2 hunks)pyproject.toml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: Build and push artifacts for Python 3.9
- GitHub Check: Build and push artifacts for Python 3.11
- GitHub Check: Build and push artifacts for Python 3.13
- GitHub Check: Build and push artifacts for Python 3.12
- GitHub Check: Build and push artifacts for Python 3.10
- GitHub Check: Test - Python 3.11
- GitHub Check: Test - Python 3.13
- GitHub Check: Test - Python 3.12
- GitHub Check: Test - Python 3.10
🔇 Additional comments (2)
pyproject.toml (1)
215-215: Poetry version constraint update aligns with CI change.Line 215 properly downgrades requires-poetry from >=2.2 to >=2.1, matching .github/workflows/ci.yml line 17 (POETRY_VERSION: "2.1.4").
.github/workflows/ci.yml (1)
17-17: Original review comment is incorrect.matplotlib-inline is a transitive dependency (visible in poetry.lock at multiple locations), not a direct dependency. It's correctly commented out in pyproject.toml because it's not directly required, yet properly appears in the CI ignore list to handle license checks for transitive dependencies pulled in by other packages. No code changes needed.
Likely an incorrect or invalid review comment.
| # so we keep vl-convert version pinned as well | ||
| "vl-convert-python==1.7.0", | ||
| "deepnote-vegafusion>=2.0.8,<3", | ||
| # "matplotlib-inline>=0.1.7,<0.2.0", # 0.2.0 is not compatible with matplotlib 3.6.3 |
There was a problem hiding this comment.
🧩 Analysis chain
Dependency commented out conflicts with PR intent.
PR title claims "downgrade matplotlib-inline for Python 3.10," but line 127 is entirely commented. Either:
- Uncomment with proper constraints (per past reviews):
- # "matplotlib-inline>=0.1.7,<0.2.0", # 0.2.0 is not compatible with matplotlib 3.6.3
+ "matplotlib-inline>=0.1.7,<0.2.0; python_version <= '3.10'", # 0.2.0 incompatible with matplotlib 3.6.3 on Python ≤3.10
+ "matplotlib-inline>=0.2.1,<0.3.0; python_version >= '3.11'",- Or if fully removing: Justify in PR description and remove from CI ignore list.
🏁 Script executed:
#!/bin/bash
# Verify current state of matplotlib-inline in pyproject.toml
echo "=== pyproject.toml around line 127 ==="
sed -n '120,135p' pyproject.toml
echo ""
echo "=== All matplotlib-inline references in repo ==="
rg -n 'matplotlib-inline' --type=toml --type=yaml --type=json
echo ""
echo "=== CI files that might reference dependencies ==="
find . -type f \( -name '*.yml' -o -name '*.yaml' \) -path '*/.github/workflows/*' | head -5Length of output: 432
🏁 Script executed:
#!/bin/bash
# Correct path and get context
echo "=== pyproject.toml lines 120-140 ==="
sed -n '120,140p' git/pyproject.toml
echo ""
echo "=== Python version markers in pyproject.toml ==="
rg -n 'python_version' git/pyproject.toml | head -10
echo ""
echo "=== matplotlib-inline in CI files ==="
rg -C2 'matplotlib-inline' git/.github/workflows/
echo ""
echo "=== Check if dependencies are pinned/ignored elsewhere ==="
rg -n 'matplotlib|0.2.0|0.1.7' git/pyproject.toml | head -15Length of output: 428
🏁 Script executed:
#!/bin/bash
# Find and inspect pyproject.toml (with repo cloning)
echo "=== Locate pyproject.toml ==="
fd 'pyproject.toml' -x echo {}
echo ""
echo "=== Lines 120-140 context ==="
fd 'pyproject.toml' -x sed -n '120,140p' {}
echo ""
echo "=== Python version markers in dependencies ==="
fd 'pyproject.toml' -x grep -n 'python_version' {} | head -15
echo ""
echo "=== Nearby matplotlib/ipython deps ==="
fd 'pyproject.toml' -x sed -n '110,160p' {}Length of output: 4143
Dependency commented out conflicts with PR intent.
PR title claims "downgrade matplotlib-inline for Python 3.10," but line 127 is entirely commented. Either:
- Uncomment with proper constraints (per past reviews):
- # "matplotlib-inline>=0.1.7,<0.2.0", # 0.2.0 is not compatible with matplotlib 3.6.3
+ "matplotlib-inline>=0.1.7,<0.2.0; python_version <= '3.10'", # 0.2.0 incompatible with matplotlib 3.6.3 on Python ≤3.10
+ "matplotlib-inline>=0.2.1,<0.3.0; python_version >= '3.11'",- Or if fully removing: Justify in PR description and remove from CI ignore list.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # "matplotlib-inline>=0.1.7,<0.2.0", # 0.2.0 is not compatible with matplotlib 3.6.3 | |
| "matplotlib-inline>=0.1.7,<0.2.0; python_version <= '3.10'", # 0.2.0 incompatible with matplotlib 3.6.3 on Python ≤3.10 | |
| "matplotlib-inline>=0.2.1,<0.3.0; python_version >= '3.11'", |
Summary by CodeRabbit