Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
RLKRo
added a commit
that referenced
this pull request
Feb 12, 2024
This commit will conflict with #328 and can be dropped.
TG tutorials are tested (without tg API) during tutorial tests.
RLKRo
requested changes
Mar 7, 2024
RLKRo
reviewed
Jun 27, 2024
Collaborator
Author
|
I believe that asynchronous interface is also ready. Could you please validate it works correctly - and we are done with it? |
Member
|
This current implementation does not support graceful termination. You can tests this by running second tutorial, requesting I think it's better to merge the async version along with #357 which provides graceful termination for all messenger interfaces. So I'd prefer to revert these last commits here and open a new PR with async version. |
- subclass from attachment - clarify doc - remove animation as possible group element - fix tutorials
They have a wierd name if filename is None
- remove original serializer to avoid warnings and improve performance - add tests - clarify usage in the docs
pseusys
force-pushed
the
feat/telegram_interface_upgrade
branch
from
0825f8e to
b1131ef
Compare
- Also store messages as objects instead of strings
I don't see a reason to pass DataAttachment instead of id
Also: - Store TelegramMessage.caption in Message.text in case TelegramMessage.text is None - Fix extra field specification for media group attachments
Otherwise, it raises an exception if the path does not exist.
remove: - message.Session - message.Command (and Message.commands) - `__eq__` methods of attachments and Message
RLKRo
approved these changes
Jul 2, 2024
RLKRo
added a commit
that referenced
this pull request
Jul 3, 2024
# Changelog ## General - Framework renamed from DFF to Chatsky (#368) ## Features - New `has_text` condition for asserting that specific text is contained inside the last request (#335) - Validation stage reworked. `Pipeline.validation_stage`, `Pipeline.verbose` and `Context.validation` fields are removed. Added new type for annotating labels `dff.script.ConstLabel` (#289) - Functions `cnd.exact_match` and `check_happy_path` now accept both `Message` and `str`. The following are now equivalent: `exact_match(Message("text"))` == `exact_match("text")` (#337) - CLIMessengerInterface moved to `messengers.console` (#328) - Attachments reworked (#328): - `Session`, `Command`, `Link`, `Button`, `Keyboard` and `Attachments` classes removed, `Message.commands` field removed. - Added `CallbackQuery`, `Contact`, `Invoice`, `Poll`, `Animation`, `Sticker`, `VoiceMessage`, `VideoMessage` and `MediaGroup` classes. - Added attachment caching feature. - Added `has_callback_query` condition. - Removed `title` field from Data Attachments. Use `caption` instead. - Telegram Messenger interface reworked (#328): - Now provides methods for attachment byte download. - Added support for receiving attachment types as members of `Message.attachments`. Others may be accessed via `Message.original_message`. - Added support for sending new attachment types (`Sticker`, `Poll`, e.t.c.). - Added support for extra options such as `disable_notification`, `message_effect_id` or `caption`. - Telegram tutorials rewritten to reflect all the changes. - Added slots that simplify the process of extracting arbitrary data from user messages and accessing it later (#36): - New user guide and tutorials on slots ## Documentation - Return PRE_RESPONSE_PROCESSING and PRE_TRANSITION_PROCESSING tutorials - New telegram interface tutorials (#328) - Slots user guide and tutorials (#36) ## Contrib - Added `poe quick_test` to run tests that are not slow and do not require docker (#344) - `Context.framework_states` renamed to `Context.framework_data` and made `Pydantic.BaseModel` (#359) - Added `MessengerInterfaceWithAttachments` class (#328) - Added tools for enabling json serialization via pickle (#328) - Telegram tests made independent from telegram servers (#328) - `wrap_sync_function_in_async` moved to `utils.devel` (#36) # Checklist - [x] I have performed a self-review of the changes - [x] Rename repos (this; template; demo) - [ ] Add new logo; change favicons in conf.py (this can be done later) - [x] Create new PyPi project and update pypi token - [ ] Create a new release - [x] Make a new release on the [final_dff_release](https://github.com/deeppavlov/dialog_flow_framework/tree/final_dff_release) branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Telegram interface was rewritten and updated to be used with the most recent
InterfaceandAttachmentclasses.Checklist
To Consider
.ignorefiles, scripts (such aslint), distribution manifest (if files are added/deleted)